Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvsw function with fixed effects leads to error #260

Closed
resulumit opened this issue Jan 28, 2022 · 1 comment
Closed

mvsw function with fixed effects leads to error #260

resulumit opened this issue Jan 28, 2022 · 1 comment

Comments

@resulumit
Copy link

The recently introduced function mvsw leads to an error in formulas with fixed effects.

This works:

library(fixest)

feols(mpg ~ cyl + mvsw(am, gear), data = mtcars)

Bu this fails:

feols(mpg ~ cyl + mvsw(am, gear) | vs, data = mtcars)

... with the following error message:

Error in feols(mpg ~ cyl + mvsw(am, gear) | vs, data = mtcars) : 
Error in str2lang(x) : <text>:1:39: unexpected symbol
1: mpg ~ cyl +  sw0(am, gear, am + gear) vs
                                          ^
@lrberge
Copy link
Owner

lrberge commented Feb 17, 2022

Thanks, it was a typo of mine. Now fixed + tests added.

@lrberge lrberge closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants