Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you feel about black code style? #4

Open
sgbaird opened this issue Aug 14, 2021 · 1 comment
Open

How do you feel about black code style? #4

sgbaird opened this issue Aug 14, 2021 · 1 comment

Comments

@sgbaird
Copy link

sgbaird commented Aug 14, 2021

Spyder allows for automatic black formatting - and I'm wondering if you're OK with me submitting a pull request that's had this auto-formatting applied to ElM2D.py.

@SurgeArrester
Copy link
Collaborator

There are some lines of code that opinionated me would disagree with black on, which is line length, e.g. keeping the if verbose: print(... statements on a single line I think looks a bit cleaner when reading through the code when there's lots of them (although many of these are a bit unnecessary at the moment).

Feel free to run it and pull and will see how it looks though, as there are definitely some other lines of code which should be broken up a bit further, and really interested to see what the function you've been working on is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants