Closes #7 division by zero fix #13
Conversation
Sorry that I merge the PR too quickly to adopt your additional documentation. Do you mind creating another PR to add these documentations to e.g. |
{{ message }}
Merged
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the division by 0 error referenced in #7.
I also made a small fix to a type error that I encountered in
model/gran_mixture_bernoulli.py, in addition to writing some additional documentation on how to set up the repository after cloning. In particular, I ran into numerous versioning issues due to a major release of networkx and matplotlib being released after this repo was published. I created a conda environments file that enforces a valid combination of dependency versions.For encapsulation purposes, I have reverted those changes on this branch, and only the division by zero fix is still included in this pull request.
You can view these other changes in the master branch of my fork here. If you like these changes and would prefer that any or all of them be included in the PR, drop a comment and I will add those changes back in or submit a new PR with all of the changes as desired.