Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use inputData.time as default timestamp #42

Merged
merged 4 commits into from Sep 15, 2021

Conversation

rodrimc
Copy link
Contributor

@rodrimc rodrimc commented Jan 1, 2021

No description provided.

index.js Outdated Show resolved Hide resolved
@tplk
Copy link
Contributor

tplk commented Sep 14, 2021

@lrlna hi, I'd like to get this PR merged, in my case I wanted to use this tool to quickly review production logs without visually analysing/parsing all available data. It was a surprise to see all log entries to have the same timestamp when read from file (i.e.,jq -c 'select(.level >= 40)' app.log | pino-colada).

There's a bug currently which I described in a review. @rodrimc, I've left a suggestion with a fix you can apply in your PR. If you don't have any time right now I can create a new PR with a fix later this week.

Thanks!

Co-authored-by: Dmitry Teplov <teplov.work@gmail.com>
index.js Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@lrlna lrlna merged commit 92089dc into lrlna:master Sep 15, 2021
@lrlna
Copy link
Owner

lrlna commented Sep 15, 2021

2.2.0 📦

Thanks for submitting and reviewing this @rodrimc @tplk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants