Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when I rotate the phone while video is loading. #12

Closed
Hexavall opened this issue Apr 24, 2021 · 3 comments
Closed

Bug when I rotate the phone while video is loading. #12

Hexavall opened this issue Apr 24, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Hexavall
Copy link

Hexavall commented Apr 24, 2021

When the video is loading and I rotate the phone without having the auto-rotation option activated, for some reason the video player detects it and this bug happens. The audio is good, but the image stills the same for the rest of the video.
Screenshot_20210424-034636

@lrorpilla
Copy link
Owner

I'll investigate this and attempt to reproduce this but in my experience, anything involving orientation is flutter_vlc_player territory. The user can always back out and try again -- and the video does load in later on when the player renderer is ready to show a frame.

@lrorpilla lrorpilla added the bug Something isn't working label Apr 24, 2021
@lrorpilla lrorpilla self-assigned this Apr 24, 2021
@lrorpilla
Copy link
Owner

I can't seem to reproduce this issue. The orientation shifts before the player has initialized.

I force this change before startup so once the player is present in the screen, the user cannot rotate to portrait and mess up the player widget. So, I am probably at the mercy of the behavior of flutter_vlc_player when rotating and how the OS handles orientation changes.

As a mitigation for this issue, the orientation is now forced in the loading screen -- this should ensure that when the player loads in, it will absolutely be in landscape and not somewhere in between.

@lrorpilla
Copy link
Owner

lrorpilla commented Apr 24, 2021

I have implemented a mitigation for this in 0.13.4.

See the relevant line in the release notes:

  • Moved landscape lock earlier from video player screen initialization to give the OS time to adjust the orientation

With that, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants