Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Custom dictionary support #24

Closed
ttu-ttu opened this issue Jul 3, 2021 · 2 comments
Closed

[Feature Request] Custom dictionary support #24

ttu-ttu opened this issue Jul 3, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ttu-ttu
Copy link

ttu-ttu commented Jul 3, 2021

Current method for monolingual dictionary seem make http calls for each look up.

Which is:

  • Extremely slow
  • Limits to one dictionary (missing quite a lot of entries)
  • Very dependent on the way this website index the words
@arianneorpilla
Copy link
Owner

arianneorpilla commented Jul 3, 2021

Timely request, this happens to be my next area to prioritize. My plan for this is to allow users to import Yomichan format dictionaries.

I already have code from 0.4 that allows me to parse term bank JSONs into dictionary entries. Loading up the JSONs every launch and doing the query with Dart data structures was not the wisest idea I had. So, what I'll do is have the user do a one-time import and store these entries in a database, probably sqflite or ObjectBox.

Then, it'll be a matter of a LIKE query limited to a certain amount of entries, favoring exact matches before starts with similarity matches. This request should also allow me to address that I can already get the lemma form of words through text segmentation, no idea why I haven't been using that as I've just found out. This should allow for offline bilingual results for JMdict almost exactly similar to Jisho.org's as I mostly use their parser.

I'll keep the current online functionality as is for users who don't want to set anything up. This is going to be quite the experiment and I hope this plan will turn out to be performant.

@arianneorpilla arianneorpilla added the enhancement New feature or request label Jul 3, 2021
@arianneorpilla arianneorpilla self-assigned this Jul 3, 2021
@arianneorpilla
Copy link
Owner

arianneorpilla commented Jul 4, 2021

I have implemented this feature in 0.24.

See the relevant line in the release notes:

  • (New Feature) Yomichan Dictionary Support - Users may now use Yomichan archive dictionaries in the application by importing them in the new Manage dictionaries option in the main menu

This feature may require more rigorous testing with a variety of dictionaries, but I am happy to release this feature given a good number of dictionaries I've tested with it. Improvements can probably come at a later time. With that, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants