Skip to content

Commit

Permalink
add libsonic as a submodule
Browse files Browse the repository at this point in the history
  • Loading branch information
@lrusak
lrusak committed Sep 27, 2016
1 parent 797a5f2 commit ad830b6
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 2,532 deletions.
3 changes: 3 additions & 0 deletions .gitmodules
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "lib/py-sonic"]
path = lib/py-sonic
url = https://github.com/crustymonkey/py-sonic.git
1 change: 1 addition & 0 deletions lib/libsonic
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
py-sonic/libsonic
32 changes: 0 additions & 32 deletions lib/libsonic/__init__.py
View file

This file was deleted.

3 comments on commit ad830b6

@gordielachance
Copy link

@gordielachance gordielachance commented on ad830b6 Sep 30, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi lrusak !

I saw you were forking the Subsonic addon for KODI, which is great since it wasn't working anymore.
I have myself worked a little on it recently.
It's my first time with Python but I managed to make some improvements, especially in the menu structure and to browse albums (more options + paging).

Once I saw this, I cloned some of your commits in my own repo (had to do manually since I don't know if there is a way to do it with Github), nice ones !

So your modifications (except that one which causes errors in my KODI) are already synced in my repo.

I was wondering if you would agree to fork my own repo instead of working on the original version, so my modifications would be included in your fork.
My goal was only to make the plugin work again and to add some basic features, but I will probably not work on this anymore as I'm just a newbie in Python.

What do you think of this ?

Here's my own fork (with some of your edits) : https://github.com/gordielachance/plugin.audio.subsonic

Thanks !

@gordielachance
Copy link

@gordielachance gordielachance commented on ad830b6 Oct 1, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this, but when running KODI on LibreELEC, the addon crashes because of the symlink I guess : it says something like 'libsonic not found'.

I posted a thread on the LibreELEC forums about this.

@lrusak
Copy link
Owner Author

@lrusak lrusak commented on ad830b6 Oct 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the interest, I'll have a look at your commits and pick them.

Please sign in to comment.