Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises, Assessment: Green diff marker in code editor hides SCA feedback marker in code editor gutter #6366

Closed
b-fein opened this issue Mar 21, 2023 · 0 comments · Fixed by #6389

Comments

@b-fein
Copy link
Contributor

b-fein commented Mar 21, 2023

Describe the bug

In the assessment view of the code editor, SCA feedback is now marked with a gutter icon.

This makes it difficult as instructor to notice that such a feedback exists.

To Reproduce

  1. Create a programming exercise with manual assessments.
  2. Submit as student to the exercise. The submission should have SCA issues.
  3. As student: The SCA issues are marked in the online code editor with yellow warning markers in the gutter.
  4. As tutor/instructor: assess the submission.
  5. The green overlay hides the SCA feedback icon. When hovering with the mouse over the relevant line, the SCA feedback text is shown as tooltip.

Expected behavior

The SCA warning is shown in the code editor in assessment mode.

Screenshots

Gutter of Shell.java
Screenshot 2023-03-21 at 15-14-56 Programming Exercises
Not shown: when hovering with the mouse over line number 72, the SCA feedback is shown as tooltip. So there should indeed be a marker.

SCA feedback in the result detail view:
Screenshot 2023-03-21 at 15-15-21 Programming Exercises

Which version of Artemis are you seeing the problem on?

6.1.1

What browsers are you seeing the problem on?

Firefox

Additional context

The issue exists both in light and dark mode.

Relevant log output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1 participant