Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Fix a visual issue with static code analysis warnings in the online editor #6389

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

b-fein
Copy link
Contributor

@b-fein b-fein commented Mar 28, 2023

Checklist

General

Client

  • I followed the coding and design guidelines and ensured that the layout is responsive.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Closes #6366.

Description

Sets the colour of the diff as background-colour instead of background. Therefore, the image for the warning is not replaced, but instead remains with the colour now in the background behind it.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Student
  • 1 Java Programming Exercise with manual assessment
  1. Submit as student to the exercise a submission that contains static code analysis issues. E.g. introduce an attribute public static int non_uppercase = 0;
  2. Start the manual assessment as instructor.
  3. The issue should be shown in the gutter like in the screenshot below in the online code editor view.

Review Progress

Code Review

  • Review 1
  • Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

For screenshots from before, check #6366.

Warning is shown with green background:
Screenshot 2023-03-28 at 10-54-55 Programming Exercises

@b-fein b-fein added this to the 6.1.3 milestone Mar 28, 2023
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Mar 28, 2023
@b-fein b-fein marked this pull request as ready for review March 28, 2023 09:05
@b-fein b-fein requested a review from a team as a code owner March 28, 2023 09:05
@b-fein b-fein added the bugfix label Mar 28, 2023
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

@b-fein b-fein requested a review from bassner March 28, 2023 09:51
@b-fein b-fein changed the title Programming exercises: Show SCA warnings in online editor assessment view Programming exercises: Fix display of SCA warnings in online editor assessment view Mar 28, 2023
@b-fein b-fein requested a review from simon-hng April 2, 2023 07:50
@bassner bassner changed the title Programming exercises: Fix display of SCA warnings in online editor assessment view Programming exercises: Fix a visual issue with static code analysis warnings in the online editor Apr 6, 2023
@bassner bassner merged commit a171d1a into develop Apr 6, 2023
@bassner bassner deleted the bugfix/assessment/online-editor-warnings branch April 6, 2023 09:19
Mtze pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) component:Programming ready to merge small user interface
Projects
None yet
4 participants