Development: Refactor quiz server tests

[laadvo]

Checklist

General

• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I followed the coding and design guidelines
• I documented the Java code using JavaDoc style.

Motivation and Context

There are many tests that do not follow the best testing practices and could be improved. There is a lot of duplicated code, overly long and unclear tests. Some assertions are missing and others are unnecessary. The PR tackels the before mentioned issues found in the QuizExerciseIntegrationTest.java class.

Description

Duplicated code has been reduced by introducing new helper functions which get reused in many tests. New and improved assertions have been in a few places and a two tests or so have been removed. Additionally, I also tried removing repository access wherever possible.

Note: there are four tests related to quiz statistics (testRecalculateStatistics, testReevaluateStatistics, testReevaluateStatistics_Practice and testReEvaluateQuizQuestionWithMoreSolutions) that I skipped. They are longer and more difficult to understand compared to other tests in the class, so I would prefer to deal with them at a later point.

Review Progress

Look through the code and make sure the refactorings make sense. The tests should be easier to understand and more efficient (less repository access).

Code Review

• Code Review 1
• Code Review 2

Test Coverage

unchanged

[codecov-commenter]

Codecov Report

Merging #6570 (4bc8cbd) into develop (23f27a4) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #6570      +/-   ##
=============================================
- Coverage      80.43%   80.41%   -0.02%     
  Complexity     13639    13639              
=============================================
  Files           2410     2410              
  Lines          91880    91880              
  Branches       12886    12886              
=============================================
- Hits           73900    73883      -17     
- Misses          9881     9898      +17     
  Partials        8099     8099              

see 12 files with indirect coverage changes

Flag	Coverage Δ
client	76.14% <ø> (ø)
server	85.07% <ø> (-0.04%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f27a4...4bc8cbd. Read the comment docs.

[JohannesStoehr]

Code looks good after other reviews and merges of develop branch

[DominikRemo]

Reapproved

[DominikRemo]

Reapproved

[julian-christl]

Code approved, thanks.

[julian-christl]

Reapproved

[DominikRemo]

Reapproved