Development: Reduce random data in server tests
#6602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikRemo
had a problem deploying
to
artemistest5
GitHub Actions
Failure
MichaelOwenDyer
previously approved these changes
May 23, 2023
terlan98
previously approved these changes
May 25, 2023
src/test/java/de/tum/in/www1/artemis/tutorialgroups/AbstractTutorialGroupIntegrationTest.java
Show resolved
Hide resolved
laadvo
previously approved these changes
May 25, 2023
MaximilianAnzinger
previously approved these changes
May 25, 2023
DominikRemo
dismissed stale reviews from MaximilianAnzinger, laadvo, and terlan98
via
6d9cdf9
github-actions
bot
added
the
client
github-actions
bot
added
cypress
…e-random-test-data" This reverts commit 6d9cdf9.
github-actions
bot
removed
cypress
laadvo
approved these changes
May 26, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #6602 +/- ##
==========================================
Coverage 80.39% 80.39%
- Complexity 13588 13589 +1
==========================================
Files 2398 2398
Lines 91683 91683
Branches 12870 12870
==========================================
+ Hits 73704 73709 +5
+ Misses 9889 9880 -9
- Partials 8090 8094 +4 see 9 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
MaximilianAnzinger
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Motivation and Context
Random test data can lead to flaky tests. Furthermore, generating random data for tests creates an unnecessary overhead compared to hard coded values.
Description
In this PR, the majority of random test data has been replaced with either hard coded values, or a combination of hard coded values and unique identifiers such as IDs.
Steps for Testing
Test changes only
Review Progress
Code Review