Development: Fix team students eager loading for several occasions

[julian-christl]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I followed the coding and design guidelines.
• I documented the Java code using JavaDoc style.

Changes affecting Programming Exercises

• High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
• I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.
• Removed Atlassian Stack as it's deprecated

Motivation and Context

After issues with #7829 and some hot fixes, I went through the whole code base to find any occurrence where loading team students might be necessary. It took some time, but I was able to go through most branches. There were a few that I had to skip because they were just too complex, but I added an initialisation on these instances, thus they are still covered.

Description

Eagerly loaded team students wherever they are called. In some areas I maintained the relations after saving by overriding them afterwards. Some queries I had to extract as participation.team.students won't work on the entity graph because team is on the student participation, not the abstract one. In some sections I load the students if not initialised. Usually because it would be too much effort to go through all call branches and make sure that every one of them loads the students for team exercises. Finally I also modified some sections to reduce database calls and improved some queries.

Steps for Testing

Prerequisites:

• 1 Instructor
• 2 Students in a team
• 1 Exercise of each type as team exercise

1. Ensure that the team administration (create, update, etc) is fully working. You can check this in the test preparation already.
2. Do all steps of the participation (submit, assess, complain, answer complain) and make sure that for every step you check all team views (i.e. the view where team members are listed).
3. Make sure that the scores are displayed correctly at all times for students and instructor alike
4. Make sure that when updating the due date of programming exercises, the repositories get locked/unlocked correctly
5. Make sure that the websocket events work especially for the students and hence the values get updated. If you're not sure what to expect, a good suggestion would be to monitor sentry during your tests and make sure that there are no errors from your server related to this PR (especially initialization errors) https://sentry.ase.in.tum.de/organizations/artemis/issues/?environment=test&project=2&statsPeriod=1h

Exam Mode Testing

Not required, exams don't support team exercises.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

No functional changes really affecting the coverage. If you really need the coverage, let me know and I'll add it.

Summary by CodeRabbit

• Refactor
  • Improved efficiency in fetching related entities for exercises.
  • Enhanced submission query methods for better data handling and added a new method for fetching specific submission associations.

[krusche]

I am not sure if the PR follows the right approach. It seems we load team and students way too often now. I guess it would be better to only load the team with students, when we actually have a team exercise

[krusche]

I made sure that the hot fix in the release branch release/6.7.7 was merged into develop to avoid a regression in 6.8.0

[julian-christl]

I am not sure if the PR follows the right approach. It seems we load team and students way too often now. I guess it would be better to only load the team with students, when we actually have a team exercise

@krusche
So do I get you right that you would prefer having two different repository methods for most of these methods and call the corresponding one depending on whether exercise.isTeamMode() resolves to false or true?
I personally don't see the benefit. If it's not a team exercise, it won't get loaded anyway. On the opposite, it would create the overload of creating many more methods and force us adapting many method signatures to pass down the information.

Or did I misinterpret your intention here?

[mateusmm01]

Tested on ts5 and works as expected 🚀

[rstief]

reapprove

[basak-akan]

Re approve

[undernagruzez]

Re approve