Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add documentation for Aeolus service #8133

Merged
merged 26 commits into from
Mar 15, 2024
Merged

Conversation

reschandreas
Copy link
Contributor

@reschandreas reschandreas commented Mar 4, 2024

Checklist

General

Motivation, Description and Context

Adding some documentation on how to setup aeolus as a service for Artemis to use.

https://artemis-platform--8133.org.readthedocs.build/en/8133/dev/setup/aeolus.html
https://artemis-platform--8133.org.readthedocs.build/en/8133/admin/setup/aeolus.html

Steps for Testing

read the newly added docs

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Summary by CodeRabbit

  • Documentation
    • Introduced the Aeolus service for custom build plan generation in the Arte application, including setup and integration instructions.
    • Added documentation for configuring Artemis to use the Aeolus service for programming exercises, supporting multiple CI systems and programming languages.
    • Included new setup instructions for the Aeolus service, detailing the installation of dependencies and configuration steps.
    • Provided instructions for setting up the Aeolus service in Jenkins and Integrated code lifecycle in Artemis, along with API key authentication details.

@artemis-bot artemis-bot added this to In progress in Artemis Development Mar 4, 2024
@reschandreas reschandreas changed the title Development: add aeolus documentation Development: Add documentation for Aeolus service Mar 4, 2024
@reschandreas reschandreas marked this pull request as ready for review March 9, 2024 15:06
@reschandreas reschandreas requested a review from a team as a code owner March 9, 2024 15:06
Copy link

coderabbitai bot commented Mar 9, 2024

Walkthrough

The recent update enhances the Arte application by integrating the Aeolus service, which provides a REST API for generating and customizing build plans for programming exercises within the Artemis platform. This enhancement enables seamless integration with various CI systems, supports the translation of Bamboo build plans, and expands customization options for programming exercises across all supported languages.

Changes

Files Change Summary
docs/.gitignore, .../generate_code_cov_table/.gitignore Added .idea/ to the .gitignore file.
docs/admin/extension-services.rst, docs/dev/setup.rst, docs/user/exercises/programming-exercise-setup.inc Introduced Aeolus service for custom build plans; added setup instructions and customization options.
docs/admin/setup/aeolus.rst, docs/dev/setup/aeolus.rst New files detailing the setup process for Aeolus, including Docker installation and Artemis configuration.
docs/conf.py Updated exclude_patterns list by adding 'venv'.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@artemis-bot artemis-bot moved this from In progress to Ready for review in Artemis Development Mar 9, 2024
Copy link
Contributor

@b-fein b-fein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall documentation looks good and is clear apart from the ‘API Keys’ section. I’ve left some smaller suggestions.

docs/admin/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/admin/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/admin/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/admin/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/dev/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/dev/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/dev/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/dev/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/dev/setup/aeolus.rst Show resolved Hide resolved
reschandreas and others added 9 commits March 10, 2024 09:24
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
b-fein
b-fein previously approved these changes Mar 10, 2024
laurenzfb
laurenzfb previously approved these changes Mar 12, 2024
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor suggestions. Other than that lgtm

docs/dev/setup/aeolus.rst Outdated Show resolved Hide resolved
docs/dev/setup/aeolus.rst Outdated Show resolved Hide resolved
@reschandreas reschandreas dismissed stale reviews from laurenzfb and b-fein via 92d3af8 March 12, 2024 19:28
reschandreas and others added 2 commits March 12, 2024 20:28
Co-authored-by: Laurenz Blumentritt <38919977+laurenzfb@users.noreply.github.com>
Co-authored-by: Laurenz Blumentritt <38919977+laurenzfb@users.noreply.github.com>
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the documentation :)

Copy link
Contributor

@mateusmm01 mateusmm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@b-fein b-fein added this to the 6.9.3 milestone Mar 14, 2024
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after changes

@krusche krusche merged commit f2b9180 into develop Mar 15, 2024
30 of 39 checks passed
@krusche krusche deleted the docs/add-aeolus branch March 15, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Artemis Development
  
Ready for review
Development

Successfully merging this pull request may close these issues.

None yet

6 participants