-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Change translations to follow new guidelines
#8139
Development
: Change translations to follow new guidelines
#8139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts2, everything seems fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts2, everything seems fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. regex makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the changes, LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the changes. Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regex & Code
|
6cee126
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Reapprove!
Checklist
General
Client
Motivation and Context
Changes all tags with jhiTranslate to conform to the new client coding guidelines specified in #8132
This also reduces the bundle size.
Description
Replaces all occurrences of text between tags with jhiTranslate using the following regex:
(<([\w-]+)[^>]* jhiTranslate=".+"[^>]*>)[^{<]*(<\/\2>)
Replacing occurrences of
artemisTranslate
has been omitted, since it might lead to failing tests and more inconsistencies in the code. Simple occurrences can be replaced by using the following regexes:(<.+)>\{\{ '([\w\d.-]*)' \| artemisTranslate \}\}(<\/.+>)
(to find)$1 jhiTranslate="$2">$3
(to replace)Steps for Testing
Run Artemis and verify no translations break
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Test Coverage
unchanged