-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Add buttons to the avatar in the course edit view and move image cropper into a modal
#8143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually on ts-3, working as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, some small comments on styling and tests
src/main/webapp/app/course/manage/image-cropper-modal.component.html
Outdated
Show resolved
Hide resolved
src/main/webapp/app/course/manage/image-cropper-modal.component.html
Outdated
Show resolved
Hide resolved
src/test/javascript/spec/component/course/course-update.component.spec.ts
Outdated
Show resolved
Hide resolved
src/test/javascript/spec/component/course/course-update.component.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just translations
…ture' into feature/dialog-for-uploading-picture
4fad2bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Showed in testing session -> everything works. My former comments have also been resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍 Thanks for changing the styling to classes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
General
: Open upload picture dialog for course when clicking imgGeneral
: Add buttons to the avatar in the course edit view and move image cropper into a modal
Checklist
General
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
Closes #7524
Description
Steps for Testing
Prerequisites:
To test it while creating a new course:
To test it while editing a course:
Testing the Dark Mode:
Testing German Version:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
Image Placeholder in English
Image Placeholder in German
Image Cropper Modal in Light Mode
Image Cropper Modal in Dark Mode
Image Removing and Editing Buttons
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style
Documentation