-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Add dynamic tab titles
#8145
Conversation
|
WalkthroughThe update involves enhancing the navigation bar component within an Angular application to manage and display dynamic tab titles. By importing necessary modules and adding new properties and methods, the component now supports setting specific titles for courses, exercises, lectures, and exams based on the current page context. This enhancement aims to improve user experience by providing clearer navigation cues. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Not needed, as the default titles are defined in the router modules.
Tested on ts3; besides Anton´s comments, Create Exam Page also just has "Create" as a tab title. Apart from that, it looks great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. The exercise import functionality is not entirely consistent:
Navigate to the management view of a course > Exercises
- Import Programming -> Title:
Import | (name of the course)
- Import Quiz -> Title:
(name of the course)
- Import Modeling, File Upload, Text exercise -> Title:
(name of the imported exercise) | (name of the course)
Maybe it could be Import (type of the exercise) | (name of the course)
?
(note: In exams > exercise groups, it's Import | (title of the exam) | (name of the course)
regardless of the exercise type)
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. All in all, looks good. We can work out any remaining inconsistencies in follow-up PRs 👍
Checklist
General
Client
Motivation and Context
Currently, Artemis only provides static tab titles defined in the router modules.
The static tab titles make navigation difficult when several tabs are open. If several tabs with the same title (e.g. "Programming Exercise") are open at the same time, navigation between the tabs is very limited.
Description
This PR extends the breadcrumb implementation of the client. Despite the most specific title of the respective page (either dynamically (e.g. exercise title) or statically) , the exercise title, the exam, the lecture title and the course title are (optionally) included. The tab titles are build from the most specific to the most general title, separate by a
|
.As a fallback, the statically defined titles in the router modules are used.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Screenshots
Summary by CodeRabbit