Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Fix an issue with the close button in the result view #8152

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

egekurt123
Copy link
Contributor

@egekurt123 egekurt123 commented Mar 7, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Solves #8135

Description

Steps for Testing

Prerequisites:

  • 1 Student
  • 1 Programming Exercise
  1. Log in to Artemis
  2. Navigate to a course and open a Programming Exercise
  3. Click at the grade (ex. 7.7% (a few seconds ago)) to open the feedback popup
  4. Make sure the button [X] is located at right above corner

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Old
Screenshot 2024-03-07 at 13 23 30

New
Screenshot 2024-03-07 at 13 20 29

@egekurt123 egekurt123 requested a review from a team as a code owner March 7, 2024 12:28
Copy link

coderabbitai bot commented Mar 7, 2024

Walkthrough

The modification introduces flexbox styling to the .feedback-header class within the feedback component's stylesheet. This change aims to enhance the layout by ensuring elements within the feedback header are spaced evenly and aligned properly, potentially addressing issues related to the positioning of UI elements such as close buttons.

Changes

File Path Change Summary
.../shared/feedback/feedback.scss Added display: flex; and justify-content: space-between; to .feedback-header.

Related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@artemis-bot artemis-bot added this to In progress in Artemis Development Mar 7, 2024
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Mar 7, 2024
@egekurt123 egekurt123 changed the title locate close button at feedbacks to right Programming Exercises: locate close button at feedbacks to right Mar 7, 2024
@egekurt123 egekurt123 changed the title Programming Exercises: locate close button at feedbacks to right Programming Exercises: Relocate Close Button of Feedbacks Mar 7, 2024
@b-fein b-fein linked an issue Mar 7, 2024 that may be closed by this pull request
Copy link
Contributor

@b-fein b-fein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.

Copy link

@AntonGeTUM AntonGeTUM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts4, works as expected

Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2 - looks good to me!

@krusche krusche changed the title Programming Exercises: Relocate Close Button of Feedbacks Programming exercises: Fix an issue with the close button in the result view Mar 9, 2024
@krusche krusche added this to the 6.9.1 milestone Mar 9, 2024
@krusche krusche merged commit 2a7863c into develop Mar 9, 2024
36 of 41 checks passed
@krusche krusche deleted the bugfix/feedback-locate-close-button-right branch March 9, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) ready to merge small
Projects
No open projects
Artemis Development
  
In progress
Development

Successfully merging this pull request may close these issues.

Feedback: The close button (X) is not located in the right corner
6 participants