-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated code lifecycle
: Add repository buttons for exams
#8155
Integrated code lifecycle
: Add repository buttons for exams
#8155
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS6 and Local CI Staging. Unfortunately, there seems to be a problem when trying to create a new exam:
2024-03-09 19:10:59.259 WARN 1 --- [nio-8080-exec-5] o.z.problem.spring.common.AdviceTraits : Bad Request: Failed to convert value of type 'java.lang.String' to required type 'long'; nested exception is java.lang.NumberFormatException: For input string: "NaN"
I don't know, how this is caused by your changes but the problem does not occur on develop
.
Concerning the code, I left some minor suggestions
src/main/java/de/tum/in/www1/artemis/service/RepositoryAccessService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/RepositoryAccessService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/RepositoryAccessService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/web/rest/ProgrammingExerciseParticipationResource.java
Outdated
Show resolved
Hide resolved
src/test/java/de/tum/in/www1/artemis/localvcci/LocalVCLocalCIIntegrationTest.java
Outdated
Show resolved
Hide resolved
…y-view-for-exams' into feature/localvc/enable-repository-view-for-exams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts6. Everything works now. Students can see the repository view during and after the exam but not before. Code also lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS6, both the student and instructor can view the repo in the exam summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS6, works as expected 👍
Integrated code lifecycle
: Add repository buttons for examsIntegrated code lifecycle
: Add repository buttons for exams
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
Currently, users can't see the repositories in the Exam Summary View. This should be enabled not only for students but also instructors, etc.
Description
Mainly, new routes have been added, as well as an open repository button in
programming-exam-summary.component
. Furthermore the logic in the server side has to be changed to allow students to open their repositories with READ access also after the exam due date.Exam Mode Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Exam Mode Test
Test Coverage
Client
Server
Screenshots
Summary by CodeRabbit
exerciseStartDate
and refined access control based on it.ExerciseDetailsStudentActionsComponent
.