Development: Remove unused variables, fields, and empty super constructor calls

[MaximilianAnzinger]

Checklist

General

• I chose a title conforming to the naming conventions for pull requests.

Server

• I strictly followed the server coding and design guidelines.
• I documented the Java code using JavaDoc style.

Description

Removes unused variables, fields, and empty super constructor calls.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Test Coverage

unchanged

Summary by CodeRabbit

Summary by CodeRabbit

• New Features
  • Enhanced submission handling with version management.
  • Improved post creation with extended associations for Exercise, Lecture, and Course.
  • Advanced quiz functionalities with new methods for Drag and Drop and Short Answer questions.
• Refactor
  • Simplified constructors across various classes for better compatibility and readability.
  • Streamlined ErrorType enumeration for consistency error reporting.
  • Updated conversation messaging service by refining dependencies and improving notification management.
• Tests
  • Updated integration and service tests with refined mock setups and simplified domain entity declarations.

[coderabbitai]

Walkthrough

The updates span across various components of the application, focusing on enhancing Java Persistence API (JPA) annotations, improving JSON serialization, and refining method implementations for handling specific domain entities. Additionally, there's a notable effort in simplifying enum declarations and constructors across several classes for better clarity and Mockito compatibility. The changes also include adjustments in service and test classes, such as refactoring, import optimizations, and removal of unused parameters and imports, aiming to streamline the codebase and its maintainability.

Changes

Files	Change Summary
.../domain/Submission.java	Added imports, modified annotations, added version handling methods.
.../domain/metis/Post.java	Enhanced JPA annotations, added getter/setter for associations.
.../domain/quiz/DragItem.java, .../DropLocation.java, .../ShortAnswerSolution.java, .../ShortAnswerSpot.java	Refined annotations and introduced mapping handling methods.
.../service/compass/umlmodel/..., .../service/dto/ConsistencyErrorDTO.java, .../metis/ConversationMessagingService.java, .../localvcci/LocalVCIntegrationTest.java, .../participation/ParticipationIntegrationTest.java, .../service/LearningPathServiceTest.java	Various refactoring, import optimizations, and simplifications for better codebase maintenance.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

.

[rstief]

Code LGTM, one small comment 👍

[milljoniaer]

Code looks good to me 🧹 🚀

[krusche]

Not sure if it makes sense to add unused getters and setters. This reduces the code coverage and does not really help to be honest

[MaximilianAnzinger]

@krusche I removed the getters and setters 👍

[julian-christl]

code

[JohannesWt]

Code looks good

[Jan-Thurner]

code LGTM