Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix column type for project type #8160

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

julian-christl
Copy link
Member

@julian-christl julian-christl commented Mar 8, 2024

Database Change

This change is backwards compatible. You can deploy it without backups. Only with Spring Boot 3 it stops being backwards compatible.

Checklist

General

Server

Motivation and Context

The field is an enum but in the DB it's an integer in string representation (varchar).

Description

I set the field to an ORDINAL enumerated and updated the column type.

Steps for Testing

Prerequisites:

  • 1 Programming Exercise
  • 1 User with access

Make sure that you can display the dasboard, access the exercise and participate in it

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • Refactor
    • Enhanced the handling of the projectType field in programming exercises for better data management.

@julian-christl julian-christl requested a review from a team as a code owner March 8, 2024 15:04
Copy link

coderabbitai bot commented Mar 8, 2024

Walkthrough

The change involves adding an annotation to the projectType field within the ProgrammingExercise class in a Java project. Specifically, the @Enumerated(EnumType.ORDINAL) annotation has been applied, which instructs how the enum value should be persisted in the database, using its ordinal number (its position in the enum declaration) rather than its name.

Changes

File Path Change Summary
.../domain/ProgrammingExercise.java Added @Enumerated(EnumType.ORDINAL) annotation to the projectType field.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@artemis-bot artemis-bot added this to In progress in Artemis Development Mar 8, 2024
@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. labels Mar 8, 2024
@julian-christl julian-christl temporarily deployed to artemis-test1.artemis.cit.tum.de March 8, 2024 17:20 — with GitHub Actions Inactive
Copy link
Contributor

@nityanandaz nityanandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual test: Executed migration successfully, locally

@krusche krusche added this to the 6.9.1 milestone Mar 10, 2024
@krusche krusche merged commit a74a5d8 into develop Mar 10, 2024
26 of 31 checks passed
@krusche krusche deleted the bugfix/fix-project-type-representation branch March 10, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. ready for review server Pull requests that update Java code. (Added Automatically!) small
Projects
No open projects
Artemis Development
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants