Development: Fix and improve URLs used in Cypress tests

[julian-christl]

Checklist

General

• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

The URLs sometimes contain trailing slashes or multiple slashes between segments. Spring Boot 3 is way more sensitive regarding such URLs. Also, when building URLs, not the best constants get used (e.g. ${BASE_URL}/courses instead of 'COURSE_BASE_URL')

Description

The constants now consistently use no trailing slashes. Hence, I had to adapt several occurrences. I also improved the usage of string template and made sure every URL build uses the best available constant.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Summary by CodeRabbit

• Refactor
  • Enhanced URL construction for improved readability and maintainability using template literals.
  • Updated base API endpoint constants to specific values for clearer API requests.
• Tests
  • Improved accuracy in URL interception and API request construction in Cypress tests.
• Chores
  • Standardized the use of template literals for string interpolation in test support files.

[coderabbitai]

Walkthrough

The changes across various Cypress test files primarily focus on improving code readability and maintainability. This is achieved by updating URL constructions and API endpoint references using template literals for better string interpolation, and by refining the constants used for base API paths. These modifications ensure more robust and readable code, making it easier to manage and understand the API requests and intercepts within the Cypress testing framework.

Changes

Files	Change Summary
src/test/cypress/e2e/course/CourseCommunication.cy.ts	Updated import statement for constants; BASE_API replaced with COURSE_BASE in GET import.
src/test/cypress/support/commands.ts	Updated URL construction in the login command to use template literals for better readability and maintainability.
src/test/cypress/support/constants.ts, src/test/cypress/support/pageobjects/...	Updated API base paths and endpoint URLs to use template literals for improved string interpolation. Refined constants for base URLs.
src/test/cypress/support/pageobjects/course/...	Updated API endpoint references and URL constructions in course-related classes to use refined constants and template literals.
src/test/cypress/support/pageobjects/exam/...	Updated base API endpoint references for exam-related operations to use COURSE_BASE and template literals for URL constructions.
src/test/cypress/support/pageobjects/exercises/..., src/test/cypress/support/pageobjects/lecture/...	Updated base API references and URL constructions in exercise and lecture-related classes to use specific constants and template literals.
src/test/cypress/support/requests/...	Updated URLs in various cy.request calls by using template literals for string interpolation and ensuring correct URL formation with proper use of slashes and constants.
src/test/cypress/support/users.ts	Updated URL construction in the CypressUserManagement class methods to use template literals for improved URL formation.

Related issues

• Development: Refactor LinkPreviewIntegrationTest #8054: The changes in this PR align with the objective of enhancing reliability and testing effectiveness by refactoring tests to use mocks for better control over external dependencies, ensuring consistent results.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[Strohgelaender]

lgtm, did not spot any issues or inconsistencies

[pzdr7]

Code looks good 👍