Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix modeling exercise assessment e2e tests #8164

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

muradium
Copy link
Contributor

@muradium muradium commented Mar 9, 2024

Checklist

General

Motivation and Context

Modeling exercise assessment tests fail on develop due to diagram elements dropped out of bounds.

Description

Sets smaller diagram boundaries and drops elements inside new bounds.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Summary by CodeRabbit

  • Refactor
    • Improved the process for adding categories in the modeling exercise creation, making it more efficient and user-friendly.

@muradium muradium requested a review from a team as a code owner March 9, 2024 09:31
@artemis-bot artemis-bot added this to In progress in Artemis Development Mar 9, 2024
@github-actions github-actions bot added tests cypress Pull requests that update cypress tests. (Added Automatically!) labels Mar 9, 2024
Copy link

coderabbitai bot commented Mar 9, 2024

Walkthrough

The update to the CreateModelingExercisePage class enhances the process of adding categories by adopting a more straightforward method. This change involves utilizing the {enter} key press after the category input, replacing a previously used workaround. This modification aims to streamline the user interaction within the modeling exercise creation workflow.

Changes

File Change Summary
.../pageobjects/exercises/modeling/CreateModelingExercisePage.ts Modified addCategories method to use {enter} key press for category addition, replacing a previous workaround.

Related issues

  • Development: Refactor LinkPreviewIntegrationTest #8054: The focus on improving test reliability suggests a broader initiative towards enhancing development practices, similar to streamlining user interactions in this PR. However, directly, this PR does not address the objectives of refactoring tests or handling external domain calls in tests.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@krusche krusche changed the title Development: Fix Cypress Modeling Exercise Assessment E2E tests Development: Fix modeling exercise assessment e2e tests Mar 9, 2024
@krusche krusche added this to the 6.9.1 milestone Mar 9, 2024
@krusche krusche merged commit 2bf2ae3 into develop Mar 9, 2024
32 of 39 checks passed
@krusche krusche deleted the test/cypress/fix-modeling-exercise-tests branch March 9, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress Pull requests that update cypress tests. (Added Automatically!) tests
Projects
No open projects
Artemis Development
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants