Programming exercises: Fix repository and participation unlock for due date change in programming exercise

[mateusmm01]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.

Changes affecting Programming Exercises

• High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).

Motivation and Context

Currently, when changing the due date from the past to the future, participations kept on being locked. This fixes #8176

Description

Two methods were switched.

Steps for Testing

Deploy on ts3, ts6 and localci-staging

Prerequisites:

• 1 Instructor
• 1 Programming Exercise

1. Log in to Artemis
2. Create a Programming Exercise with the due date in the past.
3. Change the due date to the future
4. Check that you can access the repositories by pushing code or opening the code editor.
5. Now change the due date again to the past and check that everything is locked
6. Try once again to change the due date to the future and check that everything works as expected

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Exam Mode Test

• Test 1
• Test 2

Test Coverage

Screenshots

Summary by CodeRabbit

Summary by CodeRabbit

• Refactor
  • Improved the management of student repositories and participations in programming exercises for enhanced reliability and performance.

[coderabbitai]

Walkthrough

The recent update primarily involves modifications in how student repositories and participations are unlocked in relation to programming exercises within a specific timeframe. The adjustments ensure that the unlocking process aligns more accurately with the updated deadlines, thereby addressing issues related to repository access post-deadline extensions. This change aims to enhance the flexibility and usability for students working on programming exercises, ensuring deadlines are dynamically applied and access issues are minimized.

Changes

File	Change Summary
.../scheduled/ProgrammingExerciseScheduleService.java	- unlockAllStudentRepositoriesAndParticipationsWithEarlierStartDateAndLaterDueDate now invokes unlockStudentRepositoryAndParticipation. - unlockAllStudentRepositoriesWithEarlierStartDateAndLaterDueDate now utilizes unlockStudentRepository.
.../exercise/programmingexercise/ProgrammingExerciseRepositoryServiceTest.java	- Added imports for ProgrammingExerciseStudentParticipation, ParticipationUtilService, and UserUtilService. - Added a constant TEST_PREFIX. - Added initialization for ParticipationUtilService, UserUtilService, and ProgrammingExerciseStudentParticipation. - Added a constant TIMEOUT_MS. - Added method calls for locking and unlocking student repositories and participations. - Updated test methods for handling repository access rights based on changes in ProgrammingExercise attributes.

Assessment against linked issues

Objective	Addressed	Explanation
Identify why the extended deadline for a programming exercise was not applied to student repositories. (#8176)	✅
Determine if the issue is related to the transfer to the new integrated code lifecycle or a general problem. (#8176)	❓	The summary does not specify if this aspect was directly addressed, suggesting further investigation might be needed.
Reproduce the issue by creating a programming exercise with a deadline, extending the deadline, and encountering errors when accessing student repositories post-deadline. (#8176)	❌	The summary focuses on the solution rather than detailing the reproduction steps or the investigation process.
Ensure that students can continue working on exercises before and after the original deadline without encountering errors like "Repository locked" or Error 500. (#8176)	✅	The change in methods for unlocking repositories and participations directly addresses this concern by potentially fixing the issue where students encountered access errors post-deadline.
Investigate the impact of the Artemis version 6.9.1 and the Chrome browser on the issue. (#8176)	❌	The summary does not mention any investigation related to specific Artemis versions or browser compatibility issues.

The table highlights that while the primary concern of ensuring students can access and work on programming exercises post-deadline extension seems to be addressed, other detailed investigations into the cause and specific scenarios like browser impact were not explicitly covered in the summary provided.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[Strohgelaender]

Can you add server tests for this?

[reschandreas]

demonstrated in testing session, code also lgtm!

[laurenzfb]

Code LGTM. Tested in testing session on TS6. Thanks for fixing this :)

[pzdr7]

Code looks good 👍