Development: Change client builder from browser esbuild to application
#8204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzdr7
temporarily deployed
to
artemis-test2.artemis.cit.tum.de
GitHub Actions
Inactive
pzdr7
changed the title
Development: Switch from browser-esbuild to application as production builderDevelopment: Change production builder from browser-esbuild to application
pzdr7
changed the title
Development: Change production builder from browser-esbuild to applicationDevelopment: Change client builder from browser-esbuild to application
undernagruzez
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
GitHub Actions
Inactive
undernagruzez
approved these changes
Mar 19, 2024
milljoniaer
approved these changes
Mar 19, 2024
coolchock
approved these changes
Mar 21, 2024
Kroko-fant
approved these changes
Mar 22, 2024
basak-akan
approved these changes
Mar 22, 2024
krusche
changed the title
Development: Change client builder from browser-esbuild to applicationDevelopment: Change client builder from browser esbuild to application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
In #6546, during the switch to Angular 16, we changed the production builder to
browser-esbuild. This builder's schema lacks theloaderoption that will be required to integrate the Monaco editor into Artemis (#8130). By switching to the preferredapplicationbuilder (that also uses esbuild), this becomes possible.Description
The changes follow the instructions for migrating to the application builder.
Since SSR does not affect us, I have configured the
outputPathproperty to output to the same directory as before (setsoutputPath.browserto""- see also this issue in the Angular repository)Steps for Testing
Verify that Artemis can still be deployed to a test server and that the client does not break.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests