-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Improve handling of exercise in reset build plan logic
#8205
Development
: Improve handling of exercise in reset build plan logic
#8205
Conversation
WalkthroughThe changes involve updating the local continuous integration (CI) service within a Java project to enhance the management of programming exercises. Specifically, a repository is now utilized to save updates to exercises directly after their build plan configurations are modified. Additionally, redundant database saving logic for exercises, when using local CI, has been removed from another part of the application, streamlining the process. Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
src/main/java/de/tum/in/www1/artemis/service/connectors/localci/LocalCIService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
I added the JPA repository to the LocalCIService and removed the platform-dependent
if
statement from the resource.Steps for Testing
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Test Coverage
does not change, trivial move of statements.
Summary by CodeRabbit