Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Unify exercise section separation #8216

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

milljoniaer
Copy link
Contributor

@milljoniaer milljoniaer commented Mar 18, 2024

Checklist

General

Client

Motivation and Context

The exercise management headlines have been underlined in the detail view, but not in the edit view.

Description

This PR makes the separation between exercise sections consistent across detail and edit views. It adds a horizontal line between every section.

Steps for Testing

Prerequisites:

  • 1 Instructor
  1. Log in to Artemis
  2. Edit/Create an exercise (programming, modeling, text, file upload
  3. Verify that the sub sections are separated by horizontal lines
  4. Verify that the sections are separated by horizontal lines on the detail page as well

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

image image

Summary by CodeRabbit

Summary by CodeRabbit

  • Style
    • Updated the style of the form status bar for better visual separation between sections.
  • Refactor
    • Enhanced the form status bar component for improved section delineation.

@milljoniaer milljoniaer requested a review from a team as a code owner March 18, 2024 13:38
Copy link

coderabbitai bot commented Mar 18, 2024

Walkthrough

The update involves enhancing the visual appeal and functionality of various components within a web application. Changes include adding a CSS class to improve styling, inserting horizontal rules for better visual separation between sections, and refining the appearance of form elements for clarity and structure.

Changes

Files Change Summary
.../detail-overview-list/detail-overview-list.component.html Added CSS class to dl elements within a loop.
.../detail-overview-list/detail-overview-list.component.scss Updated styles: removed underline from .section-headline, added bottom border to .section-detail-list.
.../file-upload/manage/file-upload-exercise-update.component.html Added <hr> elements for section separation.
.../exercises/modeling/manage/modeling-exercise-update.component.html Inserted <hr> elements between sections for clarity.
.../exercises/programming/manage/update/*.html Added <hr> with margin bottom for section division.
.../exercises/programming/manage/update/update-components/*.html Removed CSS classes from section elements.
.../text/manage/text-exercise/text-exercise-update.component.html Included <hr> for improved section distinction.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Mar 18, 2024
rstief
rstief previously approved these changes Mar 18, 2024
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@JohannesWt JohannesWt self-requested a review March 18, 2024 15:46
JohannesWt
JohannesWt previously approved these changes Mar 18, 2024
Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change - code looks good

Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2. Looks good for Programming/File Upload/Text/Modeling exercises. Should this apply to quizzes at all?

@milljoniaer milljoniaer marked this pull request as draft March 19, 2024 18:00
@milljoniaer milljoniaer dismissed stale reviews from JohannesWt and rstief via f2391e4 March 19, 2024 20:21
@milljoniaer milljoniaer changed the title General: Make exercise edit sub-headlines underlined General: Unify exercise section separation Mar 19, 2024
@milljoniaer milljoniaer marked this pull request as ready for review March 19, 2024 20:27
Copy link
Contributor

@b-fein b-fein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes and updated screenshots look good. I like the new design! 👍

@pzdr7 pzdr7 temporarily deployed to artemis-test2.artemis.cit.tum.de March 20, 2024 11:44 — with GitHub Actions Inactive
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2 - looks good!

Copy link
Contributor

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer approved 👍

@MaximilianAnzinger MaximilianAnzinger added this to the 6.9.4 milestone Mar 20, 2024
@krusche krusche merged commit a0b9610 into develop Mar 20, 2024
49 of 52 checks passed
@krusche krusche deleted the chore/unify-edit-headlines branch March 20, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants