-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Fix potential null pointer exception during server tests
#8218
Conversation
WalkthroughThe modification in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Development
: Fix rare NullPointerException during server testsDevelopment
: Fix potential null pointer exception during server tests
Checklist
General
Motivation and Context
Sometimes the server tests fail due to a NullPointerException in the
QuizScheduleService#stopSchedule()
method:Description
There is a concurrency issue in this method. We first call
isNull()
and afterwardsget()
, assuming that the value returned byget()
cannot be null. However with parallel server tests, the value can get set to null between these calls, leading to this exception.Steps for Testing
code review
Review Progress
Code Review
Summary by CodeRabbit