-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Use a record for TutorialGroupFreePeriodDTO
#8223
Development
: Use a record for TutorialGroupFreePeriodDTO
#8223
Conversation
WalkthroughThe update primarily focuses on enhancing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
I think the DTO should still be its own file, just as a record instead of a class file. |
...ain/java/de/tum/in/www1/artemis/web/rest/tutorialgroups/TutorialGroupFreePeriodResource.java
Outdated
Show resolved
Hide resolved
Development
: Use a record for TutorialGroupFreePeriodDTO
…t as a record again." This reverts commit ce3fca5.
src/main/java/de/tum/in/www1/artemis/web/rest/dto/TutorialGroupFreePeriodDTO.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Checklist
General
Server
Motivation and Context
The changes adopt
theTutorialGroupFreePeriodDTO
to follow the server coding guidelines. This PR improves quality and consistency throughout the code base.Description
The TutorialGroupFreePeriodDTO is now a record and not a Java class anymore. The affected parts of the code were modified to conform to that change.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Test Coverage
Summary by CodeRabbit
TutorialGroupFreePeriodDTO
to a record class for more efficient data handling.TutorialGroupFreePeriodResource
to align with the new record class structure.TutorialGroupFreePeriod
.