Development: Fix service issue during startup

[laurenzfb]

Checklist

General

• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I strictly followed the server coding and design guidelines.

Motivation and Context

#8228 replaces the @Component annotation with a @Service annotation in the IrisDefaultTemplateService. This class is final which does not work with spring services (see relevant stackoverflow post and causes the server start up to fail.

Description

Removed final from IrisDefaultTemplateService

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Summary by CodeRabbit

Summary by CodeRabbit

• Refactor
  • Removed the final modifier from the IrisDefaultTemplateService class to enhance flexibility in extending the class.
  • Added a check in ArchitectureTest to ensure classes annotated with @Service do not have the FINAL modifier.

[coderabbitai]

Walkthrough

The modification involves adjusting the accessibility of the IrisDefaultTemplateService class within a Java project. Specifically, the final keyword has been removed from the class declaration, transitioning it from a non-extendable class to one that can now be subclassed. This change suggests a shift towards a more flexible design, potentially to allow for customization or extension of the class's functionality. Additionally, a new check has been added in the test file to ensure classes annotated with @Service do not have the FINAL modifier.

Changes

File Path	Change Summary
.../service/iris/IrisDefaultTemplateService.java .../architecture/ArchitectureTest.java

• Removed final modifier from IrisDefaultTemplateService class declaration
• Added check for classes annotated with @Service to not have the FINAL modifier. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[reschandreas]

thanks for fixing this

[mateusmm01]

Tested locally and works now! Thank you 🙏