Messages: Fix creation and display of direct messages

[julian-christl]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• I strictly followed the server coding and design guidelines.
• I documented the Java code using JavaDoc style.

Motivation and Context

In a testing session we found out that currently

• if you already had an open DM, you can't create another one, but receive a 500
• the name of your DM partner does not get displayed, neither in the sidebar nor in the headline after opening

Description

This issue was introduced because of a misunderstanding of how the JPA queries work. I reverted the changes and documented the queries to prevent future confusion. Additionally, I improved the method names of the query methods.

Steps for Testing

Prerequisites:

• 1 Instructor
• Multiple Students registered
• Course with Messages enabled

1. Try to create multiple DMs with different students
2. Try to create a DM with a student that already has a DM with another person
3. Make sure the creation works, the student's name gets displayed in the sidebar and when opening the DMs on top.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Summary by CodeRabbit

Summary by CodeRabbit

• Refactor
  • Enhanced participant data retrieval in one-to-one chat features for improved efficiency in filtering based on user and course IDs.

[coderabbitai]

Walkthrough

The update primarily focuses on refining the database query operations within the OneToOneChatRepository class. It revises the JOIN FETCH operations by adjusting the entities and conditions involved, aiming to enhance the retrieval and filtering process of participant information based on specific user and course IDs. Additionally, changes in ConversationService and OneToOneChatService impact how conversations are retrieved and handled within the system.

Changes

File Path	Change Summary
.../metis/conversation/OneToOneChatRepository.java .../metis/conversation/ConversationService.java .../metis/conversation/OneToOneChatService.java	Adjusted database queries and method calls to improve participant data retrieval and conversation handling based on user and course IDs.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

disregarded oos

[pzdr7]

Tested on TS2. Looks good to me 👍

[rstief]

Tested on ts2, works as expected. Code also looks good to me 👀

[coolchock]

code lgtm

[milljoniaer]

Code looks good 👍