Development: Remove unused repository methods

[julian-christl]

Checklist

General

• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

We don't need the methods, so we can remove them. Also added an architecture test to prevent unused methods in repositories.

Description

I ran an inspection on the project and auto-removed all occurrences of unused methods.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

[coderabbitai]

Walkthrough

This update streamlines the codebase by removing unused or redundant methods, consolidating similar functionalities, and enhancing code maintainability. Key areas of focus include the simplification of repository interfaces by eliminating specific query methods, consolidating methods with overlapping functionalities, and removing unnecessary annotations. Additionally, a new test ensures the absence of unused repository methods, further promoting code cleanliness and efficiency.

Changes

File Path	Change Summary
.../domain/participation/ProgrammingExerciseParticipation.java	Removed java.util.Set import and getResults() method.
.../repository/BuildJobRepository.java	Removed methods for finding BuildJob entities.
.../repository/CompetencyProgressRepository.java	Removed deleteAllByUserId method.
.../repository/CourseRepository.java	Removed specific query methods and isCommunicationEnabled method.
.../repository/ExerciseRepository.java	Removed findByIdWithCompetenciesBidirectional method.
.../repository/ExerciseUnitRepository.java, .../repository/GradingCriterionRepository.java, .../repository/GradingInstructionRepository.java, .../repository/LectureRepository.java, .../repository/LectureUnitRepository.java, .../repository/OrganizationRepository.java, .../repository/ParticipantScoreRepository.java, .../repository/StatisticsRepository.java, .../repository/StudentExamRepository.java, .../repository/TeamRepository.java, .../repository/UserRepository.java, .../repository/hestia/CoverageFileReportRepository.java, .../repository/hestia/CoverageReportRepository.java, .../repository/hestia/ExerciseHintActivationRepository.java, .../repository/hestia/ProgrammingExerciseSolutionEntryRepository.java, .../repository/hestia/ProgrammingExerciseTaskRepository.java, .../repository/hestia/TestwiseCoverageReportEntryRepository.java, .../repository/iris/IrisSessionRepository.java, .../repository/metis/conversation/ConversationNotificationRepository.java, .../repository/metis/conversation/ConversationRepository.java, .../repository/metis/conversation/OneToOneChatRepository.java, .../repository/tutorialgroups/TutorialGroupSessionRepository.java	Removed various specific and unused methods.
.../repository/FileUploadSubmissionRepository.java	Consolidated methods and updated findByIdWithEagerResultAndAssessorAndFeedback.
src/test/java/.../ArchitectureTest.java	Added testNoUnusedRepositoryMethods() test method.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

disregarded

[nityanandaz]

Thanks for cleaning

[egekurt123]

LGTM

[MaximilianAnzinger]

Maintainer approved