Development: Remove legacy resource

[krusche]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

Remove deprecated code that is not needed any more.

Description

The code resulted from a breaking change quite some time ago and was planned to be removed for the 7.0.0 release

Steps for Testing

It is not really possible to test the change

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

Code Review

• Code Review 1
• Code Review 2

Summary by CodeRabbit

• Refactor
  • Updated security configurations by refining HTTP request handling for improved application security. Note: Planned removal of legacy code in April 2024.
  • Removed legacy result handling logic from various files and functions, focusing on notification plugin updates for successful test information.

[coderabbitai]

Walkthrough

The recent update in the project's security configuration entails the removal of specific request matchers for HTTP methods linked to certain endpoints. This change aims at cleaning up legacy code, with an explicit note indicating further removals planned for April 2024, suggesting a phase-wise cleanup strategy to enhance the project's security posture by simplifying and updating the access control mechanisms.

Changes

File Path	Change Summary
.../www1/artemis/config/SecurityConfiguration.java	Removed specific request matchers for HTTP methods on certain endpoints. Note added for further legacy code removal in April 2024.
.../exercises/programming/shared/instructions-render/service/programming-exercise-instruction.service.ts	Removed isLegacyResult import and related logic handling. Assumed test success if no feedback item is present.
.../exercises/programming/shared/utils/programming-exercise.utils.ts	Removed legacy result handling logic and functions. Updated notification plugin for successful test information.
.../spec/component/utils/programming-exercise.utils.spec.ts	Removed isLegacyResult function and associated test cases. Refactored or relocated logic related to legacy results. Eliminated test cases for isLegacyResult.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.