Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Update server dependencies #8276

Merged
merged 9 commits into from
Apr 1, 2024

Conversation

krusche
Copy link
Member

@krusche krusche commented Mar 30, 2024

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I strictly followed the server coding and design guidelines.

Motivation and Context

Keep server dependencies up to date

Steps for Testing

Make sure all relevant checks pass

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • New Features
    • Dependency updates for improved stability and performance.
  • Bug Fixes
    • Corrected SQL query references in documentation to enhance query logic.
    • Adjusted column names in the database schema for clarity and consistency.
  • Documentation
    • Updated references and conditions in SQL queries within the developer guidelines.
  • Refactor
    • Simplified constructors in various DTOs using record syntax and streamlined annotations.
    • Updated methods to improve clarity and adjust visibility in continuous integration connectors.
    • Enhanced error message handling in programming exercise feedback creation.
  • Chores
    • Added TODO comments for future conversions to record syntax in DTOs.
  • Style
    • Removed unnecessary @JsonIgnore annotations to align with serialization and deserialization changes.

@krusche krusche requested a review from a team as a code owner March 30, 2024 16:06
Copy link

coderabbitai bot commented Mar 30, 2024

Walkthrough

The recent updates encompass a series of dependency version upgrades in the build.gradle file, adjustments in the gradle.properties file to update key versions, and code modifications across various Java classes to enhance clarity, adapt to new column names, refine serialization/deserialization processes, and improve error message handling. These changes collectively aim to maintain the project's dependencies up-to-date, streamline the database schema, and enhance the project's codebase for better readability and functionality.

Changes

File(s) Summary
build.gradle Updated several dependencies including com.google.cloud.tools.jib, net.sourceforge.plantuml:plantuml, org.springframework.cloud dependencies, io.netty:netty-all, com.google.protobuf:protobuf-java, net.bytebuddy:byte-buddy, and org.json:json for testing.
gradle.properties Updated fasterxml_version and liquibase_version.
docs/dev/guidelines/criteria-builder.rst Updated SQL query references from groups. to groups.user_groups and modified the Count function operation.
src/main/java/de/tum/in/www1/artemis/domain/.../PersistentAuditEvent.java, PlagiarismResult.java Changed column names in annotations for clarity and consistency.
src/main/java/de/tum/in/www1/artemis/domain/.../User.java, UserGroup.java Updated column name annotations from "groups" to "user_groups".
src/main/java/de/tum/in/www1/artemis/service/connectors/.../BambooBuildResultNotificationDTO.java, LocalCIBuildResult.java, AbstractBuildResultNotificationDTO.java Adjusted serialization annotations and return types for methods dealing with commit hashes and branch names.
src/main/java/de/tum/in/www1/artemis/service/connectors/ci/.../AbstractContinuousIntegrationResultService.java, TestCaseDTO.java, TestSuiteDTO.java Simplified constructor using record syntax, updated annotations, and clarified score setting and test message handling.
src/main/java/de/tum/in/www1/artemis/service/dto/.../StaticCodeAnalysisReportDTO.java, TestCaseDTOInterface.java Added TODO comments for conversion to records and removed @JsonIgnore annotation from getMessage() method.
src/main/java/de/tum/in/www1/artemis/service/programming/ProgrammingExerciseFeedbackCreationService.java Enhanced error message handling by filtering out stack traces and handling specific exceptions.
src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/... Updated feedback text handling based on the actual feedback text.

This table encapsulates the essence of the changes, grouping files by the nature of their updates for a clearer overview.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) documentation database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. labels Mar 30, 2024
@github-actions github-actions bot added the tests label Mar 31, 2024
Comment on lines +149 to +150
final var buildFailed = newResult.getFeedbacks().stream().allMatch(Feedback::isStaticCodeAnalysisFeedback);
latestSubmission.setBuildFailed(buildFailed);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated logic for determining buildFailed based on the presence of only static code analysis feedback is a sensible improvement. It might be helpful to add a comment explaining this logic for future maintainers.

+ // A build is considered failed if all feedbacks are static code analysis feedback, indicating no test cases were executed.
  final var buildFailed = newResult.getFeedbacks().stream().allMatch(Feedback::isStaticCodeAnalysisFeedback);

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
final var buildFailed = newResult.getFeedbacks().stream().allMatch(Feedback::isStaticCodeAnalysisFeedback);
latestSubmission.setBuildFailed(buildFailed);
// A build is considered failed if all feedbacks are static code analysis feedback, indicating no test cases were executed.
final var buildFailed = newResult.getFeedbacks().stream().allMatch(Feedback::isStaticCodeAnalysisFeedback);
latestSubmission.setBuildFailed(buildFailed);

@krusche krusche added this to the 7.0.0 milestone Mar 31, 2024
@krusche krusche merged commit 129318e into develop Apr 1, 2024
31 of 36 checks passed
@krusche krusche deleted the chore/update-server-dependencies branch April 1, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment. documentation ready for review server Pull requests that update Java code. (Added Automatically!) tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant