Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Upgrade deprecated PMD rules #8293

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

Strohgelaender
Copy link
Contributor

@Strohgelaender Strohgelaender commented Apr 2, 2024

Checklist

General

Motivation and Context

The default PMD configuration contains some deprecated PMD rules that got removed in PMD 7.

Description

This PR prepares for the PMD 7 upgrade by repacing the rules with their successor.

Steps for Testing

Create a new Java programming exercise with SCA enabled.

Check the build logs and verify that no more ruleset deprecation warnings are present.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • Chores
    • Updated the PMD tool version to 6.55.0 for improved code analysis.

This comment was marked as off-topic.

@JohannesWt JohannesWt self-requested a review April 3, 2024 12:43
Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes look good

@Strohgelaender Strohgelaender added this to the 7.0.0 milestone Apr 4, 2024
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@krusche krusche merged commit 722b5ff into develop Apr 5, 2024
21 of 26 checks passed
@krusche krusche deleted the chore/deprecated-pmd-rules branch April 5, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants