Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive learning: Add knowledge area management #8309

Merged
merged 118 commits into from
Apr 17, 2024

Conversation

rstief
Copy link
Contributor

@rstief rstief commented Apr 4, 2024

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I strictly followed the server coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Adds the functional requirement 2.3 described in #8001

Description

Adds the possbility to manage knowledge areas to the standardized competency management. this includes the following actions:

  • Creating
  • Deleting
  • Updating
  • Moving to other parent knowledge areas

Steps for Testing

Prerequisites:

  • 1 Admin Account!
  1. Go to Server Administration -> Feature Toggles and activate Standardized Competencies
  2. Go to Server Administration -> Standardized Competencies
  3. Test that the filtering by title works, only competencies containing the filter string should show
  4. Test that the filtering by knowledge area works, only competencies in that area and direct ancestors should show
  5. Test inserting knowledge areas
  6. Test deleting knowledge areas (with children and competencies)
  7. Test updating a knowledge areas:
  8. general updates
  9. moving to another knowledge area/removing the parent
  10. test that moving a knowledge area to a knowledge area not in the filter makes it "dissapear"

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Client

Class/File Line Coverage Confirmation (assert/expect)
admin-standardized-competency.service.ts 100%
knowledge-area-detail.component.ts 98.41%
standardized-competency-detail.component.ts 100%
standardized-competency-management.component.ts 88.61%
standardized-competency.model.ts 100%

Server

Class/File Line Coverage Confirmation (assert/expect)
KnowledgeArea.java 100%
KnowledgeAreaRepository.java 100%
KnowledgeAreaService.java 97%
StandardizedCompetencyService.java 95%
AdminStandardizedCompetencyResource.java 96%
KnowledgeAreaDTO.java 100%
StandardizedCompetencyDTO.java 100%

Screenshots

image
image

Summary by CodeRabbit

  • New Features
    • Enhanced functionality for creating, updating, and deleting knowledge areas and competencies in the admin interface.
    • Introduced HTML templates and components for streamlined management of knowledge areas and competencies.
  • Refactor
    • Improved management of knowledge areas and competencies in the admin panel, enhancing tree structures and editing capabilities.

rstief and others added 30 commits March 3, 2024 21:26
…ry.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…dgeAreaService.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 14, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 15, 2024
Copy link
Member

@julian-christl julian-christl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy \o/

Code looks good!

Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code still looks good :)

Copy link
Contributor

@coolchock coolchock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approve

Copy link
Contributor

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer approved

@MaximilianAnzinger MaximilianAnzinger changed the title Adaptive Learning: Add knowledge area management Adaptive learning: Add knowledge area management Apr 17, 2024
@krusche krusche merged commit 018d6b6 into develop Apr 17, 2024
26 of 30 checks passed
@krusche krusche deleted the feature/adaptive-learning/knowledge-area-management branch April 17, 2024 10:42
@krusche krusche added this to the 7.0.1 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) component:AdaptiveLearning feature server Pull requests that update Java code. (Added Automatically!) tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants