Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix playwright tests failing after introduction of sidebar #8336

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

muradium
Copy link
Contributor

@muradium muradium commented Apr 8, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.
  • I documented the TypeScript code using JSDoc style.

Motivation and Context

Some tests fail after sidebar was introduced for exercise and lecture views.

Description

This PR adapts playwright e2e tests to new UI changes.

Steps for Testing

Run all playwright tests and confirm they pass.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@muradium muradium requested a review from a team as a code owner April 8, 2024 10:23
Copy link

coderabbitai bot commented Apr 8, 2024

Walkthrough

This set of changes collectively enhances test reliability and accuracy across various components by refining selectors, altering method signatures, and shifting the focus from IDs to more descriptive attributes like exercise titles. The modifications aim to improve test stability, compatibility, and the overall clarity of test intentions, ensuring a more robust and maintainable test suite.

Changes

Files Change Summary
.../e2e/course/CourseExercise.spec.ts Modified test to filter exercises by titles, adjusting expectations accordingly.
.../e2e/exercise/modeling/ModelingExerciseManagement.spec.ts Updated test case logic for student visibility of unreleased modeling exercises.
.../e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts Changed function signature and assertion method in quiz visibility test.
.../support/pageobjects/course/CourseCommunicationPage.ts Updated method to use a different locator for message search.
.../support/pageobjects/course/CourseOverviewPage.ts Revised locator strategy and method signatures for exercise retrieval.
.../support/pageobjects/exercises/ExerciseResultPage.ts Modified selector in shouldShowScore method for improved specificity.

Possibly related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the tests label Apr 8, 2024
@krusche krusche merged commit b436223 into develop Apr 8, 2024
21 of 26 checks passed
@krusche krusche deleted the test/playwright/fix-tests-that-use-sidebar branch April 8, 2024 14:04
@krusche krusche added this to the 7.0.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants