Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Fix date time picker issues for modeling, text, and file upload exercises #8340

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

laurenzfb
Copy link
Contributor

@laurenzfb laurenzfb commented Apr 8, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.

Motivation and Context

When creating a modeling, text or file upload exercise, the date time picker for the dates (start date, due date, assessment date) should suggest the value of the previous field as the default like it is the case in programming exercises. E.g. if you select 15:30 h as the release date, the date time picker should suggest 15:30 h for the start date and so on.

Description

Adapted the update component htmls for the different exercises to provide the described functionality.

Steps for Testing

Test for modeling, text and file upload exercise

Prerequisites:

  • 1 Instructor
  1. Open create exercise view
  2. Select a date in the past or future for the release date
  3. Select date for start date: The date time picker should suggest the value from the release date
  4. Choose a different time for the start date (e.g. 1 min later)
  5. Check the same for due date and then assessment date

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Apr 8, 2024
@laurenzfb laurenzfb marked this pull request as ready for review April 8, 2024 13:23
@laurenzfb laurenzfb requested a review from a team as a code owner April 8, 2024 13:23
Copy link

coderabbitai bot commented Apr 8, 2024

Walkthrough

The recent updates focus on enhancing the usability of date pickers across various exercise management components in a web application. By introducing [startAt] and [min] bindings, the modifications ensure that the selection of dates is restricted and guided by specific properties of each exercise type. Additionally, an adjustment has been made to make the minimum and maximum date inputs optional in a shared date-time picker component, improving flexibility in date range selection.

Changes

File Path Change Summary
.../file-upload/manage/.../file-upload-exercise-update.component.html Added [startAt] and [min] to date pickers based on fileUploadExercise properties.
.../modeling/manage/.../modeling-exercise-update.component.html Added [startAt] and [min] to date pickers based on exercise properties.
.../text/manage/text-exercise/.../text-exercise-update.component.html Added [startAt] and [min] to date pickers based on textExercise dates.
.../shared/date-time-picker/date-time-picker.component.ts Made min and max inputs optional in FormDateTimePickerComponent.

Possibly related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link
Contributor

@Jan-Thurner Jan-Thurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code 👍

Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ts6 works as expected.

Copy link
Contributor

@milljoniaer milljoniaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@krusche krusche added this to the 7.0.0 milestone Apr 8, 2024
@krusche krusche merged commit e09da6f into develop Apr 8, 2024
43 of 49 checks passed
@krusche krusche deleted the bugfix/date-time-picker-issue branch April 8, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants