Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Fix spacing in quiz navigation #8341

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

JohannesWt
Copy link
Contributor

@JohannesWt JohannesWt commented Apr 8, 2024

Checklist

General

Client

Motivation and Context

The quiz navigation sizes was 100% covering the exercise header. --> see Testing session 7.0.0

Description

Replaced custom css with bootstrap built in styling

Screenshots

Before

The quiz navigation has been implemented with much custom css which led to an overlap of the left hand quiz navigation (left bubbles showing the response status of the quiz questions) and the different headers
Screenshot 2024-04-09 at 21 30 22

After

The custom css has been replaced with using default css classes of bootstrap.
Screenshot 2024-04-09 at 21 32 23

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 exam with quiz exercises
  1. Log in to Artemis
  2. Navigate to Course Administration
  3. Do a test run
  4. Open the quiz exercise

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

unchanged

@JohannesWt JohannesWt added client Pull requests that update TypeScript code. (Added Automatically!) bugfix labels Apr 8, 2024
@JohannesWt JohannesWt self-assigned this Apr 8, 2024
@JohannesWt JohannesWt marked this pull request as ready for review April 8, 2024 14:04
@JohannesWt JohannesWt requested a review from a team as a code owner April 8, 2024 14:04
Copy link

coderabbitai bot commented Apr 8, 2024

Walkthrough

The update aims to refine the user interface of the quiz exam submission component by repositioning elements, adjusting styles, and enhancing the layout for improved visual appeal and user interaction. These modifications seek to streamline navigation and elevate the overall user experience within the quiz section.

Changes

File Path Change Summary
.../quiz-exam-submission.component.html Repositioned elements, adjusted classes, and modified quiz layout.
.../quiz-exam-submission.component.scss Restructured styles, removed specific properties, and adjusted styles for quiz elements.

Possibly related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

laurenzfb
laurenzfb previously approved these changes Apr 8, 2024
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demonstrated in testing session, looks good

rstief
rstief previously approved these changes Apr 8, 2024
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demonstrated in testing session works as expected.

milljoniaer
milljoniaer previously approved these changes Apr 8, 2024
Copy link
Contributor

@milljoniaer milljoniaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session, works as expected 👍

… 'help' instead of 'click' as nothing can be clicked there.
@JohannesWt JohannesWt dismissed stale reviews from milljoniaer, rstief, and laurenzfb via 4fc4330 April 9, 2024 12:53
Copy link

github-actions bot commented Apr 9, 2024

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Apr 9, 2024
@JohannesWt JohannesWt removed the deployment-error Added by deployment workflows if an error occured label Apr 9, 2024
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-tested works as expected

Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

Copy link
Contributor

@Jan-Thurner Jan-Thurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm 👍

Copy link
Contributor

@rabeatwork rabeatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer approved

@krusche krusche changed the title Exam Mode: Fix spacing in quiz navigation in exam mode Exam mode: Fix spacing in quiz navigation in exam mode Apr 9, 2024
@krusche krusche added this to the 7.0.0 milestone Apr 9, 2024
@krusche krusche changed the title Exam mode: Fix spacing in quiz navigation in exam mode Exam mode: Fix spacing in quiz navigation Apr 9, 2024
@krusche krusche merged commit bbb1075 into develop Apr 9, 2024
41 of 52 checks passed
@krusche krusche deleted the fix/quiz-navigation branch April 9, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants