-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Enhance architecture tests
#8344
Conversation
src/test/java/de/tum/in/www1/artemis/AbstractArchitectureTest.java
Outdated
Show resolved
Hide resolved
add arch test add integration test and refactor TutorialGroup code fix ArchCondition name refactor architecture tests and add more move StudentExamRepository getIndividualDueDate to ExerciseDateServiceual
e34298c
to
823e1d0
Compare
WalkthroughThe recent changes in the project focus on refining methods, adjusting imports, and introducing new architectural tests to enhance code quality and maintain consistency across different layers. These modifications aim to improve the overall architecture and maintainability of the Java project. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
TODO: enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
src/main/java/de/tum/in/www1/artemis/service/tutorialgroups/TutorialGroupScheduleService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, thanks for splitting up the long ArchtectureTest
class.
src/test/java/de/tum/in/www1/artemis/architecture/RepositoryArchitectureTest.java
Outdated
Show resolved
Hide resolved
406f0a6
a85b300
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Checklist
General
Server
Motivation and Context
To maintain and improve the code quality of our project, solid architecture tests are necessary.
Description
Refactors our existing architecture tests and adds multiple new ones.
Review Progress
Code Review