Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Fix missing spacing at the end of exercise in exams #8345

Merged
merged 7 commits into from
Apr 10, 2024

Conversation

mateusmm01
Copy link
Contributor

@mateusmm01 mateusmm01 commented Apr 8, 2024

Checklist

General

Changes affecting Programming Exercises

  • High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
  • I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.

Motivation and Context

When creating programming exercise without online editor the problem statement gets truncated at the end of the page. This shouldn't be like that
image

Exam Mode Testing

Prerequisites:

  • 1 Instructor
  • 1 Students
  • 1 Exam with a Programming Exercise without Online Editor
  1. Log in to Artemis
  2. Participate in the exam as a student
  3. Make sure that the UI of the programming exercise in the exam mode now shows the whole problem statement when opening the exrércise.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Apr 8, 2024
@mateusmm01 mateusmm01 marked this pull request as ready for review April 8, 2024 15:19
@mateusmm01 mateusmm01 requested a review from a team as a code owner April 8, 2024 15:19
Copy link

coderabbitai bot commented Apr 8, 2024

Walkthrough

The recent update involves adding class="mb-4" to a <div> element in exam-participation.component.html to adjust spacing. This change aims to enhance the layout and spacing within the component for improved visual presentation and user experience.

Changes

File Path Change Summary
src/main/webapp/app/exam/participate/exam-participation.component.html Added class="mb-4" to a <div> element

Possibly related issues

  • UX(Excercises): Text too wide #7648: While not directly related, the focus on enhancing user experience through layout adjustments in this PR aligns with the objective of improving readability and user interaction in Artemis, as highlighted in the issue about setting a max-width for task descriptions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

laurenzfb
laurenzfb previously approved these changes Apr 8, 2024
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

rstief
rstief previously approved these changes Apr 8, 2024
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok 👀

…exam-exercises' into bugfix/add-spacing-at-bottom-of-exam-exercises
@mateusmm01 mateusmm01 dismissed stale reviews from rstief and laurenzfb via e00fa8c April 9, 2024 08:36
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rabeatwork rabeatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer approve

@krusche krusche changed the title Exam Mode: Fix missing spacing at the end of exercise in exams Exam mode: Fix missing spacing at the end of exercise in exams Apr 10, 2024
@krusche krusche added this to the 7.0.0 milestone Apr 10, 2024
@krusche krusche merged commit 79643bc into develop Apr 10, 2024
25 of 30 checks passed
@krusche krusche deleted the bugfix/add-spacing-at-bottom-of-exam-exercises branch April 10, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready to merge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants