Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Cleanup home component after JIRA removal #8346

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

krusche
Copy link
Member

@krusche krusche commented Apr 8, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.

Motivation and Context

We still have some old code regarding captchas in JIRA. This PR removes it to make the client code for the login easier

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Programming Exercise with Complaints enabled
  1. Log in to Artemis
  2. Try out wrong and correct credentials
  3. Try out external and internal accounts

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) labels Apr 8, 2024
@krusche krusche added this to the 7.0.0 milestone Apr 10, 2024
@krusche krusche marked this pull request as ready for review April 10, 2024 20:51
@krusche krusche requested a review from a team as a code owner April 10, 2024 20:51
Copy link

coderabbitai bot commented Apr 10, 2024

Walkthrough

The recent updates aim to enhance system efficiency and user experience. Changes include adjusting logging levels for improved performance, refining error handling by using more general exceptions, and simplifying the front-end logic to streamline the user interface and boost application responsiveness.

Changes

File Path Change Summary
.../ldap/LdapAuthenticationProvider.java Logging levels switched from info to debug for user operations.
.../web/rest/open/PublicUserJwtResource.java Added import for BadCredentialsException; updated exception handling.
.../home/home.component.html Simplified UI logic by removing unnecessary conditions and adjusting error messages.
.../home/home.component.ts Removed redundant properties and simplified error handling in promises.
.../i18n/de/home.json Removed externalUserManagementWarning message from localization data.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 795d4a5 and d1f5b50.
Files selected for processing (1)
  • src/main/webapp/i18n/en/home.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/main/webapp/i18n/en/home.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 10, 2024
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 10, 2024
pzdr7
pzdr7 previously approved these changes Apr 10, 2024
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

src/main/webapp/i18n/de/home.json Show resolved Hide resolved
@@ -19,7 +19,6 @@
"failedToLogin": "<span class='bold'>Fehler bei der Anmeldung!</span> Bitte überprüfe deinen Login und dein Passwort und versuche es erneut.",
"usernameIncorrect": "<p class='text-primary small'>Ungültiger Login</p>",
"tumWarning": "<p class='text-primary small'>Wenn du Studierende:r an der TUM bist, sollte deine Kennung das Format <b>ab12xyz</b> haben.<br />Füge <b>weder</b> '<b>@mytum.de</b>' noch '<b>@tum.de</b>' hinzu.</p>",
"externalUserManagementWarning": "<span class='bold'>Du hast dein Passwort zu oft falsch eingegeben. :-(</span><br />Bitte öffne <a href='{{ url }}' target='_blank'>{{ name }}</a>, melde dich mit deinen Zugangsdaten an und löse das <a href='{{ url }}' target='_blank'>CAPTCHA</a>. Nachdem du es gelöst hast, versuche erneut dich hier einzuloggen.",
"loginWarning": "Scheint so, als hättest du Probleme bei der Anmeldung :-(<br />Bitte besuche <a href='{{ url }}'>{{ name }}</a> und versuche dich dort anzumelden.<br />Danach versuche es hier noch einmal.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this too (en & de)

@krusche krusche dismissed stale reviews from pzdr7 and coderabbitai via d1f5b50 April 11, 2024 09:31
@krusche krusche merged commit 4c61aae into develop Apr 11, 2024
14 of 18 checks passed
@krusche krusche deleted the chore/cleanup-home branch April 11, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review server Pull requests that update Java code. (Added Automatically!)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants