-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Cleanup home component after JIRA removal
#8346
Conversation
WalkthroughThe recent updates aim to enhance system efficiency and user experience. Changes include adjusting logging levels for improved performance, refining error handling by using more general exceptions, and simplifying the front-end logic to streamline the user interface and boost application responsiveness. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
@@ -19,7 +19,6 @@ | |||
"failedToLogin": "<span class='bold'>Fehler bei der Anmeldung!</span> Bitte überprüfe deinen Login und dein Passwort und versuche es erneut.", | |||
"usernameIncorrect": "<p class='text-primary small'>Ungültiger Login</p>", | |||
"tumWarning": "<p class='text-primary small'>Wenn du Studierende:r an der TUM bist, sollte deine Kennung das Format <b>ab12xyz</b> haben.<br />Füge <b>weder</b> '<b>@mytum.de</b>' noch '<b>@tum.de</b>' hinzu.</p>", | |||
"externalUserManagementWarning": "<span class='bold'>Du hast dein Passwort zu oft falsch eingegeben. :-(</span><br />Bitte öffne <a href='{{ url }}' target='_blank'>{{ name }}</a>, melde dich mit deinen Zugangsdaten an und löse das <a href='{{ url }}' target='_blank'>CAPTCHA</a>. Nachdem du es gelöst hast, versuche erneut dich hier einzuloggen.", | |||
"loginWarning": "Scheint so, als hättest du Probleme bei der Anmeldung :-(<br />Bitte besuche <a href='{{ url }}'>{{ name }}</a> und versuche dich dort anzumelden.<br />Danach versuche es hier noch einmal.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this too (en & de)
Checklist
General
Client
Motivation and Context
We still have some old code regarding captchas in JIRA. This PR removes it to make the client code for the login easier
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests