Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Adjust validation bar styles #8347

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

milljoniaer
Copy link
Contributor

@milljoniaer milljoniaer commented Apr 8, 2024

Checklist

Client

  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

makes circles smaller, fixes client tests

Steps for Testing

Prerequisites:

  • 1 Instructor
  1. Log in to Artemis
  2. Edit Programming exercise
  3. Circles in validation bar are smaller

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

image

@milljoniaer milljoniaer requested a review from a team as a code owner April 8, 2024 15:39
Copy link

coderabbitai bot commented Apr 8, 2024

Walkthrough

This set of changes involves updates to the visual and functional aspects of form status indicators and checklist checks in a web application. The modifications include adjusting icon sizes, refining layout in the status bar, and streamlining component logic by removing unused lifecycle hooks. These changes aim to enhance user interface consistency, reduce code complexity, and improve the overall user experience.

Changes

Files Change Summary
.../form-status-bar.component.html
.../checklist-check.component.html
Updated to adjust icon sizes and introduce dynamic sizing based on properties.
.../form-status-bar.component.scss Altered positioning and size of elements within the form status bar for improved layout.
.../form-status-bar.component.ts Removed AfterViewInit lifecycle hook and related resizing logic.
.../checklist-check.component.ts Added SizeProp import and size input property for dynamic icon sizing.
.../exercise-update-plagiarism.component.spec.ts Modified to use non-null assertion operator for accessing fieldCPCEnabled, enhancing code robustness.

Possibly related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) labels Apr 8, 2024
laurenzfb
laurenzfb previously approved these changes Apr 8, 2024
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pixel magic approve

rstief
rstief previously approved these changes Apr 8, 2024
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session. lgtm

JohannesWt
JohannesWt previously approved these changes Apr 8, 2024
Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

kaancayli
kaancayli previously approved these changes Apr 8, 2024
Copy link
Contributor

@kaancayli kaancayli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work as expected. Approved

JohannesWt
JohannesWt previously approved these changes Apr 8, 2024
Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

laurenzfb
laurenzfb previously approved these changes Apr 8, 2024
kaancayli
kaancayli previously approved these changes Apr 8, 2024
Copy link
Contributor

@kaancayli kaancayli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

rstief
rstief previously approved these changes Apr 8, 2024
rabeatwork
rabeatwork previously approved these changes Apr 8, 2024
Copy link
Contributor

@rabeatwork rabeatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainer approved

MichaelOwenDyer
MichaelOwenDyer previously approved these changes Apr 8, 2024
Copy link
Contributor

@MichaelOwenDyer MichaelOwenDyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bellissimo

@krusche krusche added this to the 7.0.0 milestone Apr 8, 2024
Copy link
Member

@krusche krusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 but we need to apply further small improvements in follow-up PRs

@krusche krusche merged commit 5d7751b into develop Apr 9, 2024
18 of 25 checks passed
@krusche krusche deleted the fix/make-validation-bar-circles-smaller branch April 9, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

8 participants