-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Show result for programming exercises on the exam overview page
#8354
Conversation
Exam mode
show updating result on the exam overview page
Exam mode
show updating result on the exam overview pageExam mode
Show updating result for programming exercises on the exam overview page
|
WalkthroughThe update involves enhancing the HTML layout for exercise overviews in exams with conditional rendering for improved exercise information display. Additionally, the test suite is expanded to include new components, ensuring seamless integration of feedback components within the Angular framework. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. Looks good - the code as well. I left one suggestion you could try 👍
...exam/participate/exercises/exercise-overview-page/exam-exercise-overview-page.component.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvement - code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session - LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in testing session, works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested during testing session, works as described
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on test server, works as expected
Exam mode
Show updating result for programming exercises on the exam overview pageExam mode
: Show result for programming exercises on the exam overview page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, programming results are shown as expected 👍
Checklist
General
Client
Motivation and Context
This PR introduces an updating result component to the exam overview page. Previously, students submitting code for automated programming exercises would only see a checkmark to indicate submission status, leading to potential misinterpretation under exam conditions. This enhancement aims to provide clearer, real-time feedback on submission outcomes, reducing misunderstanding and stress during exams.
Description
The jhi-exam-exercise-overview-page component now has a jhi-updating-result component.
Steps for Testing
Exam Mode Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Screenshots