-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Prevent problem statement from closing when viewing changes
#8355
Conversation
Exam mode
: Prevent problem statement from closing when viewing the differenceExam mode
: Prevent problem statement from closing when viewing changes
WalkthroughThis update enhances the user interaction within an exam context by refining the problem statement update mechanism. Specifically, it modifies how events are handled when toggling the highlighted state of problem statements, ensuring a more intuitive and controlled user experience by preventing event propagation. Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
...ate/exercises/exam-exercise-update-highlighter/exam-exercise-update-highlighter.component.ts
Show resolved
Hide resolved
Co-authored-by: Julian Christl <julian.christl@tum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested during testing session, works as described. Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested during a testing session and works as expected, code also lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested during testing session, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in testing session, works as expected.
Checklist
General
Client
Motivation and Context
During the second testing session for 7.0.0, we noticed that clicking on the "Show Difference" / "Only show new Version" buttons closed the problem statement for some exercise types.
This was because the problem statement (which collapses when clicked) registered a click when the button was clicked.
Description
stopPropagation
occursSteps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests