-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Update problem statement content only if there is a new change
#8356
Conversation
WalkthroughThe recent updates aim to enhance the user experience in exam exercises by refining the problem statement update process and improving update visibility. These changes involve adjusting service behaviors, updating HTML templates for better UI control, and introducing properties for managing component visibility. The goal is to facilitate clearer communication of updates and modifications within exam exercises. Changes
Possibly related issues
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
...ate/exercises/exam-exercise-update-highlighter/exam-exercise-update-highlighter.component.ts
Outdated
Show resolved
Hide resolved
…ls1intum/Artemis into bugfix/exam-exercise-update-highlighter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
99617ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see any such button on TS2, code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested during testing session, works as described 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested during the testing session today, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually Tested during testing session on ts4, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session; works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested in the Testing Session 👍
Exam mode
: Update content only if there is a new changeExam mode
: Update problem statement content only if there is a new change
Checklist
General
Client
Motivation and Context
After submitting the exam, "Click Show the difference" button can still be seen on the exam overview page and clicking the button does not show any difference. This PR makes sure that after submission, the button is not visible.
Description
Changed the
BehaviorSubject
to regularSubject
inexam-exercise-update.service.ts
Exam Mode Testing
Prerequisites:
Note
Prevent refreshing your browser while following the steps.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Exam Mode Test
Screenshots
Before submission:
After submission: