Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling exercises: Fix assessment page title #8357

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

loreanvictor
Copy link
Contributor

@loreanvictor loreanvictor commented Apr 8, 2024

Checklist

General

Client

  • I strictly followed the client coding and design guidelines.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

When assessing a modelling exercise (or reviewing an assessment), the title of the page would be Apollon Diagram {{ title }} (issue originally reported by @pzdr7 ).

Description

This PR will instead use another (already existing) translation message consistent with programming exercises. It will be Modeling Exercises in English or Modellierungsaufgaben in German.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Students
  • 1 Modeling Exercise
  1. Log in to Artemis as the student
  • Alternatively, use the instructor, but add them as a student to the course as well
  1. Make a submission to the exercise
  2. Log in to Artemis as the instructor
  3. Assess the submission
  4. Check the title of the page (title of the tab)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Screenshot 2024-04-09 at 01 27 13

@loreanvictor loreanvictor requested a review from a team as a code owner April 8, 2024 23:29
Copy link

coderabbitai bot commented Apr 8, 2024

Walkthrough

This update focuses on enhancing the user experience by modifying the page titles in the ModelingAssessmentEditorComponent route configuration. The titles are updated to better reflect the content and purpose of the modeling exercises, aiming for a more intuitive navigation and identification process for users.

Changes

File Path Change Summary
.../modeling/assess/modeling-assessment-editor.route.ts Updated page titles from 'artemisApp.apollonDiagram.detail.title' to 'artemisApp.modelingExercise.home.title'.

Possibly related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Apr 8, 2024
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code looks good
  • Tested on TS3, works as expected

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Strohgelaender Strohgelaender changed the title Fix title of assessment page for modeling exercises Modeling exercises: Fix assessment page title Apr 9, 2024
@krusche krusche added this to the 7.0.0 milestone Apr 10, 2024
@krusche krusche merged commit fb89289 into develop Apr 10, 2024
23 of 28 checks passed
@krusche krusche deleted the bugfix/modeling-assessment-title-issue branch April 10, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants