Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Remove publish build plan feature #8360

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

krusche
Copy link
Member

@krusche krusche commented Apr 9, 2024

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I strictly followed the server coding and design guidelines.
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I documented the TypeScript code using JSDoc style.

Changes affecting Programming Exercises

  • High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).

Motivation and Context

This feature is not used actively and would not work any more due to the migration to LocalVC and LocalCI

Description

One feature less makes the code easier to maintain

Steps for Testing

Prerequisites:

  • 1 Instructor
  1. Create a course programming exercise and make sure you can edit it

Exam Mode Testing

Prerequisites:

  • 1 Instructor
  1. Create an exam programming exercise and make sure you can edit it

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) documentation cypress Pull requests that update cypress tests. (Added Automatically!) template labels Apr 9, 2024
mateusmm01
mateusmm01 previously approved these changes Apr 9, 2024
Copy link
Contributor

@mateusmm01 mateusmm01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

laurenzfb
laurenzfb previously approved these changes Apr 9, 2024
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Code also lgtm

@krusche krusche marked this pull request as ready for review April 10, 2024 20:20
@krusche krusche requested a review from a team as a code owner April 10, 2024 20:20
@krusche krusche added this to the 7.0.0 milestone Apr 10, 2024
Copy link

coderabbitai bot commented Apr 10, 2024

Walkthrough

This update involves adjustments to the support for programming language features in continuous integration environments and a refactoring in the AutomaticProgrammingExerciseCleanupService class to use ProfileService. Additionally, a method call for setPublishBuildPlanUrl in ProgrammingExerciseTestService.java has been removed.

Changes

Files Change Summary
.../programming-exercise-features.inc Illustrates changes in supported features for various programming languages in CI setups.
.../AutomaticProgrammingExerciseCleanupService.java Refactored to use ProfileService for profile operations, with added logic for skipping cleanup in LocalCI systems.
.../ProgrammingExerciseTestService.java Removed setPublishBuildPlanUrl method call for exercise4.

Possibly related issues

  • Missing Build plans of imported exercise #7439: Although this PR does not directly address the issue of missing build plans for imported exercises, the changes made could indirectly impact related behaviors by streamlining features and operations within the platform. Further investigation is needed to determine if these changes have any bearing on the issues outlined.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 2032605 and 78df9ac.
Files selected for processing (3)
  • docs/user/exercises/programming-exercise-features.inc (2 hunks)
  • src/main/java/de/tum/in/www1/artemis/service/scheduled/AutomaticProgrammingExerciseCleanupService.java (5 hunks)
  • src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseTestService.java (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • docs/user/exercises/programming-exercise-features.inc
  • src/main/java/de/tum/in/www1/artemis/service/scheduled/AutomaticProgrammingExerciseCleanupService.java
  • src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseTestService.java

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 10, 2024
@krusche krusche merged commit fd4125d into develop Apr 11, 2024
20 of 26 checks passed
@krusche krusche deleted the chore/remove-publish-build-plan-url branch April 11, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) cypress Pull requests that update cypress tests. (Added Automatically!) documentation ready for review server Pull requests that update Java code. (Added Automatically!) template tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants