Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Make the global footer shorter #8361

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

krusche
Copy link
Member

@krusche krusche commented Apr 9, 2024

Checklist

General

Client

  • I translated all newly inserted strings into English and German.

Steps for Testing

Just check the footer with wide and small width in German and English

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@krusche krusche requested a review from a team as a code owner April 9, 2024 12:20
Copy link

coderabbitai bot commented Apr 9, 2024

Walkthrough

The recent updates focus on improving user interaction and localization across the web application. Key changes include relocating contact information within the "About Us" section, refining footer component links, and updating translation files for better clarity and relevance. Additionally, adjustments in test scripts reflect these UI and textual modifications, ensuring consistency and accuracy in automated testing environments.

Changes

File Path Change Summary
.../about-us.component.html Moved contact information section for better template organization.
.../footer/footer.component.html
.../footer/footer.component.ts
Updated links and translations in the footer, including changing requestChangeUrl to feedbackUrl and removing the import of VERSION.
i18n/de/global.json
i18n/de/legal.json
i18n/en/global.json
i18n/en/legal.json
Added "releases" key and updated "requestChange" to "feedback" in German and English localization files. Added a "privacy" key-value pair in legal sections.
.../support/pageobjects/LoginPage.ts
.../support/pageobjects/LoginPage.ts (Playwright)
Modified method to adapt to the changed selector from #request-change to #feedback in test scripts.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@krusche krusche changed the title General: Make the sticky footer shorter General: Make the global footer shorter Apr 9, 2024
@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) cypress Pull requests that update cypress tests. (Added Automatically!) labels Apr 9, 2024
@krusche krusche added this to the 7.0.0 milestone Apr 9, 2024
@krusche krusche merged commit d83588a into develop Apr 9, 2024
21 of 27 checks passed
@krusche krusche deleted the chore/shorter-footer branch April 9, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) cypress Pull requests that update cypress tests. (Added Automatically!) tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant