Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Fix and issues when printing to PDF #8364

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

coolchock
Copy link
Contributor

@coolchock coolchock commented Apr 9, 2024

Checklist

General

Description

In the testing session for 7.0.0 it was noticed that while trying to export an exam to PDF only the first page is exported and the scroll bar is visible in the PDF. Actually, that is the case not only in the exam overview, but in general. This pull requests fixes the mentioned problem.

Steps for Testing

Prerequisites:

  • 1 Student
  • 1 Exam
  1. Log in to Artemis
  2. Go to an exam and submit it
  3. In the exam overview page click "export to PDF"
  4. Check if the whole exam is exported
  5. Please also check if other pages are correctly printed to PDF

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Apr 9, 2024
@coolchock coolchock added deploy:artemis-test3 and removed deployment-error Added by deployment workflows if an error occured labels Apr 9, 2024
@coolchock coolchock temporarily deployed to artemis-test3.artemis.cit.tum.de April 9, 2024 21:25 — with GitHub Actions Inactive
@coolchock coolchock marked this pull request as ready for review April 9, 2024 22:00
@coolchock coolchock requested a review from a team as a code owner April 9, 2024 22:00
Copy link

coderabbitai bot commented Apr 9, 2024

Walkthrough

This update introduces a CSS adjustment aimed at improving the print functionality of web content. By setting overflow: visible !important for all elements during print operations, it ensures that entire documents are printed without truncation and removes the scroll bar from printouts, enhancing the visual quality and completeness of printed PDFs.

Changes

File Path Change Summary
.../webapp/content/scss/global.scss Added a rule to make overflow: visible !important for all elements when printing.

Possibly related issues

  • Exam: Export PDF summary not printing collapsed exercises properly #7333: The CSS change could impact the printing behavior of programming exercises in Artemis, potentially addressing issues with elements' height consideration and the proper rendering of collapsed or expanded exercises during PDF export. The modification ensures that content does not get cut off, which aligns with the objectives to correct printing discrepancies in the Artemis platform.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coolchock coolchock added ready for review client Pull requests that update TypeScript code. (Added Automatically!) small and removed ready for review client Pull requests that update TypeScript code. (Added Automatically!) lock:artemis-test3 labels Apr 9, 2024
Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good & tested on TS3 -> works as expected

Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

@krusche krusche added this to the 7.0.0 milestone Apr 10, 2024
@krusche krusche changed the title General: Fix printing to PDF Exam mode: Fix and issues when printing to PDF Apr 10, 2024
@krusche krusche merged commit 0a4250e into develop Apr 10, 2024
62 of 69 checks passed
@krusche krusche deleted the bugfix/print-all-exam-pages branch April 10, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants