Development: Extend exam user tests

[julian-christl]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I strictly followed the server coding and design guidelines.

Motivation and Context

#8207 exposed gaps in the exam user test.

Description

For the exam user image upload and the signature collection I added the use cases to update the corresponding files.
To do this, I reactivated and fixed a recently deactivated test. Additionally, I found out that the one issue we found in the PR did also occur for the exam user images, hence I fixed this issue.

Exam Mode Testing

Upload the images for the exam user twice, make sure nothing changes, and all images are where they belong after the second upload.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Exam Mode Test

• Test 1

Test Coverage

Class/File	Line Coverage	Confirmation (assert/expect)
ExamUserRessource.java	100%	✅

[coderabbitai]

Walkthrough

This update introduces efficient data retrieval methods for programming exercises, refines image handling in exam services, and enhances testing frameworks for exam functionalities. It aims to optimize performance, improve testing coverage, and ensure functionality correctness across various components of the Artemis platform.

Changes

File Path	Change Summary
.../ProgrammingExerciseRepository.java .../ProgrammingExerciseTestRepository.java	Added method to efficiently load exercises with specific participations using EntityGraph.
.../ExamUserService.java	Updated image path handling in the saveImages method.
.../ExamUserIntegrationTest.java	Enabled and refined tests for exam user functionalities, including attendance verification.
.../ProgrammingExerciseTestService.java	Refactored setup logic for programming exercises in exams, improved test setup.

Possibly related issues

• Enable StudentExamIntegrationTests #8291: The enhancements in testing frameworks, particularly for exam functionalities, align with the objectives to enable and improve integration tests.
• Enable ExamParticipationIntegrationTest > testGetExamScore #8297: The enabling and refining of exam-related tests in ExamUserIntegrationTest.java could directly contribute to achieving the objectives of this issue.
• Enable ExamUserIntegrationTest > testVerifyExamUserAttendance #8289: The changes made in ExamUserIntegrationTest.java to enable the testVerifyExamUserAttendance are directly addressing the objectives of this issue.
• Enable ProgrammingExamIntegrationTest > unlockAllRepositories #8305: Although the PR does not directly mention unlocking repositories, the general enhancement of testing capabilities could indirectly support the objectives related to testing enhancements in the ProgrammingExamIntegrationTest.
• Programming Exercise: Changing the short name while importing breaks tests #7188: If any of the refactored test setups or new methods involve changes in handling exercise names, this could potentially address the issue with the test.json file breaking during imports.

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 5869fc9 and 0712407.

Files selected for processing (2)

• src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseTestService.java (3 hunks)
• src/test/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseTestRepository.java (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/test/java/de/tum/in/www1/artemis/exercise/programmingexercise/ProgrammingExerciseTestService.java

Additional Context Used

Path-based Instructions (1)

src/test/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseTestRepository.java (1)

Pattern src/test/java/**/*.java: test_naming: descriptive; test_size: small_specific; fixed_data: true; junit5_features: true; assert_use: assertThat; assert_specificity: true; archunit_use: enforce_package_rules; db_query_count_tests: track_performance; util_service_factory_pattern: true; avoid_db_access: true; mock_strategy: static_mocks; context_restart_minimize: true

Additional comments not posted (3)

src/test/java/de/tum/in/www1/artemis/repository/ProgrammingExerciseTestRepository.java (3)

76-77: The implementation of findAllWithTemplateAndSolutionParticipationByIdIn using EntityGraph for optimized fetching of template and solution participations is well-designed and adheres to performance best practices.

---

9-9: The import of EntityGraph is correctly placed and necessary for the annotations used in the repository.

---

3-3: The import of LOAD from EntityGraph.EntityGraphType is appropriate and necessary for specifying the fetch type in the EntityGraph annotation.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nityanandaz]

Manual test (local): Could upload successfully exam user images via PDF multiple times

[MaximilianAnzinger]

Maintainer approved 👍

[krusche]

Code looks good